From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65414: save-some-buffers-functions are unexpectedly called when save-some-buffers pred is non-nil Date: Sun, 20 Aug 2023 21:06:54 -0700 Message-ID: <871qfxvvw9.fsf@breatheoutbreathe.in> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36151"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jonas@bernoul.li To: 65414@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 21 06:54:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXwvk-0009EN-H6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Aug 2023 06:54:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXwvT-00038h-84; Mon, 21 Aug 2023 00:54:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXwvQ-00038J-Ms for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 00:54:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXwvQ-0006Yz-85 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 00:54:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXwvS-0005Jc-6T for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 00:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 04:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65414 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169259363120413 (code B ref -1); Mon, 21 Aug 2023 04:54:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Aug 2023 04:53:51 +0000 Original-Received: from localhost ([127.0.0.1]:55189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXwvG-0005JB-Vz for submit@debbugs.gnu.org; Mon, 21 Aug 2023 00:53:51 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:49062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXwvE-0005Iy-R3 for submit@debbugs.gnu.org; Mon, 21 Aug 2023 00:53:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXwv7-00037h-I4 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 00:53:41 -0400 Original-Received: from out-55.mta0.migadu.com ([2001:41d0:1004:224b::37]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXwv4-0006Xn-Dn for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 00:53:41 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1692593610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=RFlY/Br+RkmnjufxzdnpAyYNXVq10TskAplvfLjIdGU=; b=a+yJkCb3eZYTrfdxMv1wD2xvcFRoFA4mjQu9D/4v6yQrTuGnHcK8B6PeWDScZ9174DdTDp WbA29PBtqtQIYA6V45qM6vOG1tpPrcuiw+HAtMIDxZowXqSY0UD9XoSkk069yMejAjHG2/ /mGbe+UaB0JeXUrKiXP01XW6DxwrrgY= X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::37; envelope-from=joseph@breatheoutbreathe.in; helo=out-55.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268056 Archived-At: Functions which are added to save-some-buffers-functions are always called when save-some-buffers runs, even when a PRED argument is specified. This leads to unexpected behavior when PRED is intended to limit saving buffers to a specific set of file buffers, as in Magit's magit-save-repository-buffers function. abbrev--possibly-save is added to save-some-buffers-functions by default now, so whenever magit-save-repository-buffers runs, Emacs prompts to save unsaved abbrevs (as well any other functions in the list). I propose that we pass along the PRED argument of save-some-buffers to each of save-some-buffers-functions, allowing them to determine what is appropriate to do. Alternatively, we could pass along the return value of files--buffers-needing-to-be-saved, which is a list of buffers. Thoughts? Joseph