From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#59458: [PATCH] Fix tracing for advanced scoring Date: Mon, 11 Sep 2023 17:07:16 -0700 Message-ID: <871qf4ntjf.fsf@ericabrahamsen.net> References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> <877czkf8g3.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31905"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Lars Ingebrigtsen , 59458@debbugs.gnu.org, =?UTF-8?Q?=C5=81ukasz?= Stelmach To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 12 02:08:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfqx1-00085f-9m for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Sep 2023 02:08:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfqwp-0006Ux-4P; Mon, 11 Sep 2023 20:08:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfqwh-0006US-6f for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 20:08:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfqwf-0003kE-MF for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 20:07:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfqwj-0006Xx-Tx for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 20:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Sep 2023 00:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59458-submit@debbugs.gnu.org id=B59458.169447725325123 (code B ref 59458); Tue, 12 Sep 2023 00:08:01 +0000 Original-Received: (at 59458) by debbugs.gnu.org; 12 Sep 2023 00:07:33 +0000 Original-Received: from localhost ([127.0.0.1]:55335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfqwH-0006X9-DJ for submit@debbugs.gnu.org; Mon, 11 Sep 2023 20:07:33 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:33250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfqwD-0006Wu-9Z for 59458@debbugs.gnu.org; Mon, 11 Sep 2023 20:07:32 -0400 Original-Received: from localhost (71-212-75-26.tukw.qwest.net [71.212.75.26]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 3C2A6FA0BA; Tue, 12 Sep 2023 00:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1694477238; bh=0S43JYvdQupgDdM246s+pq7WCQ6dIVQvTc4cp4YR/Ko=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=v+1lzs1/66QscE1H2hGDpZg0BHPTAQAeyWo+FLuAE2alaTgFIFoqjVhWCa6wr1eN6 PGtg49orbAhf/AXCR2tcX30G756tYT3mX38fBtnVCQ6e5jpXYf9KPtEDkN/54elMmm CdSQ7w7EoViXxoW5jRzzdS37ZgKTw4g0adbB4TNE= In-Reply-To: (Stefan Kangas's message of "Thu, 7 Sep 2023 14:07:57 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270112 Archived-At: On 09/07/23 14:07 PM, Stefan Kangas wrote: > Eric Abrahamsen writes: > >> Eli Zaretskii writes: >> >>>> Cc: =C5=81ukasz Stelmach >>>> From: =C5=81ukasz Stelmach >>>> Date: Mon, 21 Nov 2022 22:30:55 +0100 >>>> >>>> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing >>>> code outside of if so it's executed for both branches. >> >> I'm not very familiar with this code (this is actually the first I'm >> hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense >> that tracing should happen whether or not the rule matched? But what >> about the sexp before that? Would we be pushing the mail-header-number >> and new score to `gnus-newsgroup-score' only if the rule *wasn't* >> successful? >> >> I think this one should wait for Lars. If we don't hear from him and >> it's holding things up, I can look more closely. > > Eric, > > It would be great if you could help review this. Thanks in advance. I've taken a closer look, and I do think this is okay. The `when' after the `dolist' only fires if the rule matches, the `if' is only there to see if this article has been previously scored or not. So moving the "(when trace" up to the top-level of the containing `when' (ie, out of the `if') does look like the right thing to do. Eric