From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Date: Tue, 03 Oct 2023 13:43:56 -0700 Message-ID: <871qebph9p.fsf@breatheoutbreathe.in> References: <87r0mni6m1.fsf@breatheoutbreathe.in> <87bkdq3nw6.fsf@web.de> <875y3yx221.fsf@breatheoutbreathe.in> <87pm260wh9.fsf@web.de> <87v8bx48ww.fsf@breatheoutbreathe.in> <87msx8sbpv.fsf@web.de> <87bkdoh1gy.fsf@breatheoutbreathe.in> <83y1gpyysv.fsf@gnu.org> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4301"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, philipk@posteo.net, 66187@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 03 22:46:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnmI0-0000rk-R8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Oct 2023 22:46:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnmHF-0000HP-Is; Tue, 03 Oct 2023 16:45:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnmH3-00006S-4g for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 16:45:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnmH2-0004kQ-KF for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 16:45:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnmHJ-0005QO-U4 for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 16:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Oct 2023 20:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66187 X-GNU-PR-Package: emacs Original-Received: via spool by 66187-submit@debbugs.gnu.org id=B66187.169636593420799 (code B ref 66187); Tue, 03 Oct 2023 20:46:01 +0000 Original-Received: (at 66187) by debbugs.gnu.org; 3 Oct 2023 20:45:34 +0000 Original-Received: from localhost ([127.0.0.1]:40783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnmGr-0005PP-QY for submit@debbugs.gnu.org; Tue, 03 Oct 2023 16:45:34 -0400 Original-Received: from out-210.mta1.migadu.com ([95.215.58.210]:18141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnmGo-0005PB-HB for 66187@debbugs.gnu.org; Tue, 03 Oct 2023 16:45:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1696365911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6GgGRNrp2heHXIgaTjLH3n2cFxOFbze8tdRS8hXib2U=; b=eSgz+tbPTf9tW1KIRdOL0FYHmGSQuKl/Hn5pusncjIOAkNhIjwyrYttiGkeIvLglqqmj0d xjSuY3TdbE/ezCAoexJNOkjx8Mf0d5BZPmQv5rGupQyg0LbEIozn99Q1YycEMa682aiCc/ lPlcizFau5Zc1z7h34+XAse+6wQJmic= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <83y1gpyysv.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271737 Archived-At: Eli Zaretskii writes: >> Cc: philipk@posteo.net, 66187@debbugs.gnu.org >> Date: Tue, 26 Sep 2023 17:55:37 -0700 >> From: Joseph Turner via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> > Finally, I think the docstring of `read-directory-name' needs to be >> > updated: it fails to mention that MUSTMATCH can be a function (the >> > argument is passed directly to `read-file-name'). >> >> How about the attached patch? > > This is okay, except that we do document the other arguments. So why > not just copy/paste the description of MUSTMATCH from read-file-name > to read-directory-name instead? The read-file-name docstring for MUSTMATCH is lengthy, and duplicating it will mean that if read-file-name changes, we'll need to remember to change the docstring of read-directory-name.