From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Wilhelm Kirschbaum Newsgroups: gmane.emacs.bugs Subject: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sat, 07 Oct 2023 12:10:43 +0200 Message-ID: <871qe6wxle.fsf@gmail.com> References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> <87leeuvtft.fsf@gmail.com> <87edi6reyf.fsf@gmail.com> <87jzryg370.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23925"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.9.3; emacs 30.0.50 Cc: Basil Contovounesios , 64275@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 07 12:13:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qp4J5-00064Z-Lg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Oct 2023 12:13:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qp4If-0001Ie-0u; Sat, 07 Oct 2023 06:12:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qp4Id-0001Ho-0b for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 06:12:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qp4Ic-0006iT-OC for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 06:12:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qp4Iw-00005Y-1H for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 06:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wilhelm Kirschbaum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 10:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64275-submit@debbugs.gnu.org id=B64275.169667354932763 (code B ref 64275); Sat, 07 Oct 2023 10:13:01 +0000 Original-Received: (at 64275) by debbugs.gnu.org; 7 Oct 2023 10:12:29 +0000 Original-Received: from localhost ([127.0.0.1]:53363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp4IP-0008WN-EU for submit@debbugs.gnu.org; Sat, 07 Oct 2023 06:12:29 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:60619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp4IN-0008W8-Cs for 64275@debbugs.gnu.org; Sat, 07 Oct 2023 06:12:28 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3231df054c4so2733832f8f.0 for <64275@debbugs.gnu.org>; Sat, 07 Oct 2023 03:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696673522; x=1697278322; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=v3zg8f/UqR8BO+vf3B0MCdh4ZkB6atw4CwbuY0xU2tk=; b=Pd+p1f9i+W46cdspVit4Q/gY6jjcZrh7lxRSU85CPDzyISddv35yQgrOaUG8xrdhZu BVJmzetTAEwSl/ZiYR7w7Nqs1J5CS7vEwvP2eYcmIxUS11C7HruLR4oa9JHE4MJ2FLEm IKZv5M5N0Q+XAumd97zeUORzhT2B/Xdf75VXjIL647QifGVskEEm00nnafNo0rSz7QdU 53qOuUg2lkvABGzB6Xs6rdj9B44K8rp28xQL2mtmzd96aAcqwVVzgIBJE2+2Jp9wUpOX ASQ9o1CUpZm28Pqx19Be4ugdUHLQZ1lUFk3Hk9VP2yNumccxIirwOWDbbVRusmiRq5KU dEzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696673522; x=1697278322; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v3zg8f/UqR8BO+vf3B0MCdh4ZkB6atw4CwbuY0xU2tk=; b=ai/7s/1bGamxVDpSnfaN8U26DAcQzdgCy+HC4cVpHI0jAWJGr7B9K0fUbt6SOY9Iuf aqMB7cLZGFJ6Igy0/V3hR2YbB5G6vFniNmHMe02ek5oYstdHzebzwkDlbpk/Ppe/I6sT dPJyTlB/5hl7ipCpC1Hqz+IJUgmc0HzCNVCENZtc0dU1vhilj+b9rMOUCHbdM0IvdnAb SFUDCd8d0XJlDz7EzXH/bU6IdlvfltAhZ+Ezg/IPe1F4IkgZSzLDq9CrEv84UP8Hj923 Fhc689+dZt45SirtvNkURu8YcKjzI6H2n86+dzS9aZFfAzmKxFpDv2yV3vq+AHu/i6Mq I1rQ== X-Gm-Message-State: AOJu0YxqiV1DR+aT0UF/l8ekTy0V/x6ejAf7ITGgBpVdEOOQsDVdU00F Hz9t7wtblWBp07FFGV11YMDkrhtOjXCq7oKx X-Google-Smtp-Source: AGHT+IEVeorGD14aI2NpVNzv+tkNNLuIea59DVknTpoWOdlPGTC9fMrIu/yoRikb4ebkFszrK2+vsQ== X-Received: by 2002:a5d:4cc3:0:b0:31f:e761:d47c with SMTP id c3-20020a5d4cc3000000b0031fe761d47cmr9019895wrt.32.1696673521911; Sat, 07 Oct 2023 03:12:01 -0700 (PDT) Original-Received: from melissa.local ([2c0f:ef18:1431:0:b09:9616:db04:c248]) by smtp.gmail.com with ESMTPSA id h11-20020a056000000b00b00325a59b2080sm3852395wrx.97.2023.10.07.03.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 03:12:01 -0700 (PDT) In-reply-to: <87jzryg370.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271989 Archived-At: Wilhelm Kirschbaum writes: >>> >>> I'm not sure what you meant by the last sentence, sorry. What >>> do >>> you >>> think about the below? >>> >>> (sigil (sigil_name) @elixir-ts-font-sigil-name-face) >>> @font-lock-string-face) >> >> Sorry for the late reply. I believe the following patch is >> more >> appropriate as it will apply the sigil font to the entire >> sigil, but >> also respect the regex face. We can add string specific >> matches >> later, >> but happy just to simplify what we have and fix apply >> appropriate >> font >> to previously unmatched sigils. >> >> [2. text/x-patch; >> 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch]... > > Actually, the above patch breaks the embedded HEEx sigils' > font. We > have to exclude it when doing a general match. Attached works > with ~H > sigils as well. Please ignore the previous patch and install > this > one. > > [2. text/x-patch; > 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode(1).patch]... Sorry :(. I am finding more edge cases. Maybe let me test it this properly this week before we make any changes.