From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrey Listopadov Newsgroups: gmane.emacs.bugs Subject: bug#67246: 30.0.50; elixir-ts-mode uses faces inconsistently Date: Sun, 03 Dec 2023 13:41:20 +0300 Message-ID: <871qc3imfq.fsf@gmail.com> References: <87y1ewgnn7.fsf@gmail.com> <9ae8eb33-fd8b-f8d6-dd7f-79f8d4464a51@gutov.dev> <87a5r2p4pq.fsf@gmail.com> <87bkbfkr1h.fsf@gmail.com> <22ea1559-f44e-933d-e60a-9caa62b376a8@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5365"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.11; emacs 30.0.50 Cc: Wilhelm Kirschbaum , 67246@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 03 11:58:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r9kAx-00019k-R6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Dec 2023 11:58:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9kAb-0002Tk-BM; Sun, 03 Dec 2023 05:57:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9kAa-0002Tc-G5 for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 05:57:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9kAa-0007yv-7d for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 05:57:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9kAk-0001fw-2k for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 05:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Listopadov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Dec 2023 10:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67246 X-GNU-PR-Package: emacs Original-Received: via spool by 67246-submit@debbugs.gnu.org id=B67246.17016010226360 (code B ref 67246); Sun, 03 Dec 2023 10:58:02 +0000 Original-Received: (at 67246) by debbugs.gnu.org; 3 Dec 2023 10:57:02 +0000 Original-Received: from localhost ([127.0.0.1]:59172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9k9l-0001eM-RJ for submit@debbugs.gnu.org; Sun, 03 Dec 2023 05:57:02 -0500 Original-Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:46281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9k9j-0001dx-Il for 67246@debbugs.gnu.org; Sun, 03 Dec 2023 05:57:00 -0500 Original-Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a1b68ae40ffso25960766b.0 for <67246@debbugs.gnu.org>; Sun, 03 Dec 2023 02:56:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701601004; x=1702205804; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=WLtrCY819MIovEcX+bpWbAHq9kaW/RZ/GVYGEHbo/RQ=; b=A+6x9NBlS1GgdSeHCJ61m5C7Klp9bsLlJltvyD0kK1ETfXfoYM0KGMgN3Thcr0PFIX B890kyHdsG8WUASSmOw5J08Iv1XQ0P0xHXj8vfEDiu867HkgJLirQhoXg2axzNHVAfdt IYtD0LE4qkwk88scjpRyLesYpIPei4E8pTK7Rm07l6cgRXvQ0Bo/BFyWY9aTOBS1yaSP pfpp3ffVneE0sEntp+wjxQXSNe6xbRh5B9g31DKqd49wA1NWoexPbRkI2JfV8ZqJ8o5n BXqDTHRIg22YqR/yFibg2GKnO0QfvlssOPRhKys32gdfL976RvJ/VTxnsiX+OpdmSAV8 YjHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701601004; x=1702205804; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WLtrCY819MIovEcX+bpWbAHq9kaW/RZ/GVYGEHbo/RQ=; b=M8rwUn9f5n3OvEKYXMJvXn/+SUFTi4K1QP+EgKWeAkstiPM0x4Q+3hgACqoXZK8b/p g2Uwl0qaycoFnNka0GXtHcsf6jZ3YxkPFg5uLm+HVCgHQjocyl/H+j/ZgoVGtaBQj0/F aiaYUki7DauIGYq7ZyFqIZJGP/ZR/VGBxGFtu1qKamw0TJbG5BXAVjKwe4+f33hbaV3P 3bzFUo8XbkYg1WEv1JHs2IrXkMG9eusikY/av7tPceX5tNRn5rtYL7PSJw9NIIVh91gm D/i4qqYxKQKNcmM45u/Y6vohJ55PuteO/1fuT5lTYIVHVqrQ4qo7s+LQTKc5fCrGr0zN X6RQ== X-Gm-Message-State: AOJu0YzwSVXq7NITX4Pgv2bZUHYLoBv4XqCJSxH23Sms7RwFkPJFXqtt vjSdzWonDcdA9/MLIvMS0kVvqe49Se4= X-Google-Smtp-Source: AGHT+IECVOZ40WqYfsU3T+7LqgNxjbfrhVX/z32shUWRiP2LGDL094Mrxx5DvDvSqah448Cxf1LbgA== X-Received: by 2002:a17:906:209e:b0:a08:17de:6409 with SMTP id 30-20020a170906209e00b00a0817de6409mr1630103ejq.7.1701601003525; Sun, 03 Dec 2023 02:56:43 -0800 (PST) Original-Received: from toolbox.smtp.gmail.com (broadband-46-242-11-135.ip.moscow.rt.ru. [46.242.11.135]) by smtp.gmail.com with ESMTPSA id z21-20020a170906715500b009fdaab907fbsm4022397ejj.188.2023.12.03.02.56.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 02:56:43 -0800 (PST) In-reply-to: <22ea1559-f44e-933d-e60a-9caa62b376a8@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275412 Archived-At: Dmitry Gutov writes: > On 27/11/2023 19:59, Wilhelm Kirschbaum wrote: >> Here is a patch to address numerous issues flagged on Elixir slack, >> Github and in this thread.=C2=A0 It will not be perfect, but since the >> changes are pretty large I want to get this in and then we can pick on >> specific issues afterwards if that makes sense? > > Thank you. No problem, pushed to master. Thanks! The code now seems to be properly highlighted. I've just tested the update and noticed that putting the `do' keyword on a separate line breaks indentation. Here's an example: defmodule Foo do # case A @moduledoc """ Test module. """ defp a(x), do: a(x, 0) defp a(x, y), do: a(x, 0, 0) # case B defp a(x, y, z) do # case C x + y + z end end I have intentionally introduced incorrect indentation before the first `do' keyword (case A), but the matching `end' keyword was indented automatically when I called `indent-region' on the whole buffer. The case B seems to be indented incorrectly, the default formatter would indent such `do:' by just two spaces after the parent `defp'. The third case C is similar to case A, except the indentation was provided by Emacs, meaning, after pressing the RET key before the `do' keyword, Emacs had put the keyword at the BOL. If there are no `do' after the closing parenthesis, the automatic indentation is correct. I'm not sure if these problems were introduced by the changes, or were present before, and if I should send a separeate bug report for them, as this isn't strictly related to highlighting, just with the tree-sitter-based indentation. -- Andrey Listopadov