From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68796: xterm.c: Convert mouse-4/5/6/7 to wheel-up/down/left/right Date: Mon, 04 Mar 2024 09:47:54 +0800 Message-ID: <871q8q3gz9.fsf@yahoo.com> References: <871q9zh972.fsf@yahoo.com> <87r0hzfpd5.fsf@yahoo.com> <86cyt4vi9r.fsf@gnu.org> <87y1bs1y9x.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2068"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 68796@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 04 02:50:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rgxSz-0000L5-Rd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Mar 2024 02:50:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rgxSQ-0004Iv-F0; Sun, 03 Mar 2024 20:49:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgxSP-0004Ik-9K for bug-gnu-emacs@gnu.org; Sun, 03 Mar 2024 20:49:33 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rgxSP-0005Xf-1b for bug-gnu-emacs@gnu.org; Sun, 03 Mar 2024 20:49:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rgxSs-0007fc-3r for bug-gnu-emacs@gnu.org; Sun, 03 Mar 2024 20:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Mar 2024 01:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68796 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68796-submit@debbugs.gnu.org id=B68796.170951694329200 (code B ref 68796); Mon, 04 Mar 2024 01:50:02 +0000 Original-Received: (at 68796) by debbugs.gnu.org; 4 Mar 2024 01:49:03 +0000 Original-Received: from localhost ([127.0.0.1]:41420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgxRv-0007at-9T for submit@debbugs.gnu.org; Sun, 03 Mar 2024 20:49:03 -0500 Original-Received: from sonic305-22.consmr.mail.ne1.yahoo.com ([66.163.185.148]:44482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgxRt-0007ZX-6t for 68796@debbugs.gnu.org; Sun, 03 Mar 2024 20:49:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1709516905; bh=t7BSgtN3a7kE/O0I/MBOW/bQhffNSLCfY8e90wcowDI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=qi5fD7VdSMSus1Zdq9sW+fOc3y0YWOY1XWIH9352SaEMaf10CuKmnrNeGexDGUsjh/EAo3Mh0LYfNlPsEgGRqP7FhfjNTdATMQIyiCrWyN9qMk+wK8KfINnIVnaxAYGoOpWdZxXk8B79syT3j2gx3BbSf6RaT6dlUkahHQbT058S1S2sO+h8p+QMWjIluGQ8H5Njd1OgvcSOg13tj0Llac4lxCNjzFrs/bV1mMZWuECJMAu3jho1aHYL5u+OiMdgmGIWJAP2g+kZ3ZCKJxVUHE2QXMdnaOFXdzEGM0b7wZUVJcHv6FxR+Xo4cMLrtlkQOuDtSsHIyW0oOkOzYpuNxg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1709516905; bh=CuypshGJfNbjJTGATzl01V/2UGiiaVeCalk8TeYJCfQ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=LhnBBrZ7gqaCwN6sUeUX+5Aez1BbU0R0TFNg2I0mMuH70d5rAiiss+oc15HLUAIo4ts4+AUOFLGKIpVXjL2ITjLBXkV336nevW9h7EkwalV/TRbs5KAHIVSZRx4sIAG85rvz4mR8ZokRk/XNLlJipmblCyb7yhgF/x6VTS1reywvjnU8hnJQXVNi0qd5SDjIpDWSnafrTyGwxu/zu1MXhRsfJf7GnVX5jqtO8aHr00uUbK9/G1sxQYIzpxAfgDQ49JGHgIDjdQnCeUW9PX9ZcPkh4hQglSFlA/ldZJIjmpMG/s3AT20dLLM/oAzhqHYzkBcMkWDGKPAm8rOzJvOajg== X-YMail-OSG: JuxJz0UVM1mTyYQM8vMRGBKAilpOqMVBpcbD.QFEdYYIC2yd5o0fDehrbOlpalH 2LcGilZ4hpTM0W2rpLGte7Dy7p4kfK8sq5cWTISdeCL1LzIlPpFJglrXO3oZ9aHCxfLODBm7gH7Z VURc8lQ4NjD.k0S8IZ.eFag6TQVwNlRmOXjmE4QXvMAu26jNRA1FraZjc8HOgPhg_d4.bASJLAVD XcUy2NeFKPBXiyM4x3FN47_gH5eWsptqzHjBXOOJqF5l2475ay6lXvT7RFYAwRXVcR_yxCzYnZAC uxJKMnUdbzXYyrV3CqzzHOaUsEqyyZtz24ybA4OZkkZU1_pUXbnU5rjNNRLTEYu5nSdUiBnq5esW pK2IUbmGyE9iUT7GvSxOVmXYuTsfFIYkvsUcAKJyVXNpaB5iTF6ZjGw_gUithlexmEzp4NA631kE GK2MQAqdiJ_h2AqIP5uB8_OU7cTBOXg2DBop.kRHvbnRLGJV3ExpCt3hCkSEKtH9r7EunsJ0TXxz p_TXaNW_63VOnHQVIt8xfzwUs8zcEW9.9Pp7Q5cOWo8AVaFTXob73eiFZRO9ui4CbhYlcuAq8VDV j7gpLGdv9n7naQMpKDV84r6WrdcKd8UL7HezLC6gaVMg7YkvNqNb8RPs9SRWBYeZkTM_scnVCvos lC2SN6lFqRRKf2UZXSEj3ARhHShlN5kq6rfeDGCjrrK2HGQkxwePT6p4vV6nuUUYP9WpZ_Ood.vE lIDLoZv87OzwL1E27YBlGjsjPYpLr56mBgCUEETubxsBkaP5JZTpdBRgOBgaAlyEXrrKYNnQ02cw kvfSE4PI642_bd.dPDWwbNHg2qBUhgBnP.zShXWbUB X-Sonic-MF: X-Sonic-ID: 28fa4467-3ab2-42cf-b9fd-0a75fccfc2b8 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Mon, 4 Mar 2024 01:48:25 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-zp62z (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 45cbc9bac2fcd6e1d8093ee5bbb128ae; Mon, 04 Mar 2024 01:48:20 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Sun, 03 Mar 2024 11:22:39 -0500") X-Mailer: WebService/1.1.22103 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280970 Archived-At: Stefan Monnier writes: > Ping? > > I believe this patch should be much less controversial since it allows > users to get the old behavior back and still keeps the same semantics > for existing `mouse-wheel-*-event` variables in case some other code > still generates such events. It's basically a half-way step between > what I proposed at first and the status quot. > > But I'd like some confirmation that you think it's acceptable, and maybe > if you could comment on the FIXME included in there (I needed it for > clicks on the tab-bar, but I don't understand that code). That would be simple if I could find the FIXME, but it doesn't appear to be present anywhere in that patch... >> + /* Convert pre-XInput2 wheel events represented as mouse-clicks. */ >> + if (!xi2) >> + { >> + Lisp_Object base >> + = Fcdr_safe (Fassq (make_fixnum (result->code + 1), >> + Fsymbol_value (Qmouse_wheel_buttons))); >> + int wheel >> + = NILP (base) ? -1 >> + : BASE_EQ (base, Qwheel_down) ? 0 >> + : BASE_EQ (base, Qwheel_up) ? 1 >> + : BASE_EQ (base, Qwheel_left) ? 2 >> + : BASE_EQ (base, Qwheel_right) ? 3 >> + : -1; This should be surrounded by parentheses. Thanks.