From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Date: Tue, 28 May 2024 06:33:08 -0700 Message-ID: <871q5moycr.fsf@neverwas.me> References: <87ikz0xrew.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12916"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , 71178@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 28 15:34:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBwy1-000344-J4 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 May 2024 15:34:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBwxg-0005RL-CT; Tue, 28 May 2024 09:33:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBwxe-0005R2-6A for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 09:33:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBwxd-0000to-Ua for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 09:33:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBwxm-0000Yp-V9 for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 09:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 May 2024 13:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71178 X-GNU-PR-Package: emacs Original-Received: via spool by 71178-submit@debbugs.gnu.org id=B71178.17169032112035 (code B ref 71178); Tue, 28 May 2024 13:34:02 +0000 Original-Received: (at 71178) by debbugs.gnu.org; 28 May 2024 13:33:31 +0000 Original-Received: from localhost ([127.0.0.1]:45986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBwxG-0000Wh-2b for submit@debbugs.gnu.org; Tue, 28 May 2024 09:33:30 -0400 Original-Received: from mail-108-mta253.mxroute.com ([136.175.108.253]:38285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBwxD-0000WS-H3 for 71178@debbugs.gnu.org; Tue, 28 May 2024 09:33:28 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta253.mxroute.com (ZoneMTA) with ESMTPSA id 18fbf67ab26000efce.001 for <71178@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 28 May 2024 13:33:13 +0000 X-Zone-Loop: 52d88d53a5f6204763b5c88a6dae64215b2356eb53f7 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=st4YvkAU+PmUGwrtD1UzQzU6uSfzTl0yCvjUHRfx0uI=; b=UIHLQMj+abF1S3HMwOEnzZUx7L N7B3L2pGYqxoiq7uLqma3DJQAmETF3yKOo/3Ffq3160WWnWp652rNFgcVs9t/soSVpu9+ueLMhCSL EBIg0BtEguMQNep1tzn7ry63UpRaRRnDjL5DcUQ5KFOUy7FLf+Zeb7IgHuCyZGgY68DaMZtkWmKK9 AUBVN+JfEebn9DXVcmxIZhuS1YAYxTi3WHxVJYi9EvEz6Ajtgs7NkTx/BcMsJ1MXHF7d6ThzLGocS krEVsyYtlh5jVrvlKd1aQqZ5GeNECXVz2dCTCWZPl0/vzTSMOQ6VZdUZOlQ7/yj3QtFCTKTfW0vqh 91mcyoOQ==; In-Reply-To: (Alan Mackenzie's message of "Mon, 27 May 2024 15:28:21 +0000") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286086 Archived-At: Hi Alan, Alan Mackenzie writes: >> It seems you have identified the underlying cause: > >> https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01140.html > > I've been looking at lisp/emacs-lisp/ert.el, and I think that suppressing > the debug output (or rather, not invoking a backtrace dump in batch mode) > is where the problem lies. However, when I enabled these in my own copy, > they produced an erc.log of over 100 MB. But that was in my customised > Emacs where I've changed quite a few things always to get a complete > backtrace. So I'm not sure what is best, here. I too have bumped into failures that don't produce a backtrace, at least in recent versions. However, the ones I typically see look more like: Error in process sentinel Make[3] *** [Makefile:184 lisp/erc/erc-*.log] Error 255 ... 1 files did not finish: lisp/erc/erc-*.log Make *** [Makefile:266 check-lisp-erc] Error 2 With these, it seems debug output is being intentionally suppressed on account of the error originating from some process sentinel or timer. And when I enable `debug-on-error', a backtrace appears as expected. This leads me to assume such occurrences are somewhat unrelated to what you're experiencing. That said, I'm fairly convinced I've encountered the odd mystery failure with no specified error. And the "aborted" line in your excerpt does look familiar. Sadly, though, I cannot reliably reproduce anything similar (yet). >> The test itself is of minimal utility and is therefore rubbish (if not >> outright vandalism), so I will remove it unless you'd rather it stick >> around until the conversation on the list gets going. > > I think I'd rather the test should stay there a bit longer. It > highlights problems in pcase.el and ert.el which might get fixed sooner > if the test is still there. _MIGHT_ (here's hoping!). Good point. I've added a FIXME to remind myself or some future person to delete the test once things have settled. Cheers, J.P.