unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Philip Kaludercic <philipk@posteo.net>,
	Eli Zaretskii <eliz@gnu.org>,
	71374@debbugs.gnu.org
Subject: bug#71374: [PATCH] Simplify 'help-enable-variable-value-editing' using
Date: Sat, 13 Jul 2024 22:53:20 +0100	[thread overview]
Message-ID: <871q3xklgv.fsf@jeremybryant.net> (raw)
In-Reply-To: <CADwFkmnwfiA-2kkvARKfw154RAJ18bixa+LVmzonON2s1E37sQ@mail.gmail.com> (Stefan Kangas's message of "Sat, 29 Jun 2024 22:38:42 -0700")

Stefan Kangas <stefankangas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> From: Philip Kaludercic <philipk@posteo.net>
>>>> Date: Wed, 05 Jun 2024 06:55:46 +0000
>>>>
>>>> The main issue with this patch is that it drops the syntax highlighting
>>>> in the *string edit* buffer, but we could fix that in a second patch by
>>>> adding support to specify a major mode to inherit from when editing a
>>>> string.
>>>
>>> Thanks.  This is basically a cleanup, yes?  IOW, there's nothing wrong
>>> with the current implementation, right?  If so, I'd prefer to wait
>>> with this until after the emacs-30 branch is cut.
>>
>> Right, it just seemed like the kind of thing where it would be natural
>> to demonstrate string-edit.
>
> Feel free to install on master now, thanks.

Philip, has this been installed on master?  Can the bug be closed?





  reply	other threads:[~2024-07-13 21:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  6:55 bug#71374: [PATCH] Simplify 'help-enable-variable-value-editing' using Philip Kaludercic
2024-06-05 12:19 ` Eli Zaretskii
2024-06-06  6:22   ` Philip Kaludercic
2024-06-30  5:38     ` Stefan Kangas
2024-07-13 21:53       ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-07-28 12:04         ` Philip Kaludercic
2024-08-02  9:03           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-12 11:51             ` Philip Kaludercic
2024-08-13  5:59               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-26 20:27                 ` Philip Kaludercic
2024-09-02 20:56                   ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q3xklgv.fsf@jeremybryant.net \
    --to=bug-gnu-emacs@gnu.org \
    --cc=71374@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jb@jeremybryant.net \
    --cc=philipk@posteo.net \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).