From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72704: 29.4; repunctuate-sentences ignores NO-QUERY Date: Sat, 31 Aug 2024 08:19:02 -0400 Message-ID: <871q24khqh.fsf@breatheoutbreathe.in> References: <87r0alazj9.fsf@breatheoutbreathe.in> <86sev1hunf.fsf@mail.linkov.net> <87seuu300z.fsf@breatheoutbreathe.in> <86y14mnzvc.fsf@gnu.org> <87jzg62w55.fsf@breatheoutbreathe.in> <86wmk6mfjb.fsf@gnu.org> <87ikvpx2yx.fsf@breatheoutbreathe.in> <86bk19cagy.fsf@gnu.org> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: briandg@gmail.com, juri@linkov.net, rms@gnu.org, 72704@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 31 14:20:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1skN5Z-000AO6-N3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Aug 2024 14:20:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1skN5K-0006da-Jo; Sat, 31 Aug 2024 08:20:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skN5J-0006d7-6i for bug-gnu-emacs@gnu.org; Sat, 31 Aug 2024 08:20:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1skN5I-0006Ih-TX for bug-gnu-emacs@gnu.org; Sat, 31 Aug 2024 08:20:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=CC6jEt3aM65NXE3csuQwEkSDe+kB3v4HXjMXeEErV04=; b=Knj/ee41vjIEztIlXLs8iaEJgERCH5oFYqzwlxFRt9TDZfqIaA5mi2etfOPJ0kJYB99EJhif9BcwvvwpsEOqSxld7kcQ2Aoje0LsOlxAbHrKGb00ywszTQKvrW3LToa7hTISEzQKr8B8EF8ZZTSR0m+kAHmd8XzMTv3k6Wp4ILFxuAKwNJH5r/rH8LILI8E8y7EMOCGDNmJHWkASJQH/gzDEiJgOa4x1x6VrU17mqdA/9ssOcXarqQMM6FkNEDRaNsgev7UZCKhOPkKc4Ve3ieWXCTiS5VU+Rdl/o5zd0L+3ObdPbgvydnl+K6c1WZQk9LZyrfWQgvvVyvJR1Bep4g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1skN6E-0005MJ-EZ for bug-gnu-emacs@gnu.org; Sat, 31 Aug 2024 08:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Aug 2024 12:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72704 X-GNU-PR-Package: emacs Original-Received: via spool by 72704-submit@debbugs.gnu.org id=B72704.172510681320513 (code B ref 72704); Sat, 31 Aug 2024 12:21:02 +0000 Original-Received: (at 72704) by debbugs.gnu.org; 31 Aug 2024 12:20:13 +0000 Original-Received: from localhost ([127.0.0.1]:54224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skN5Q-0005Km-Ck for submit@debbugs.gnu.org; Sat, 31 Aug 2024 08:20:12 -0400 Original-Received: from out-181.mta1.migadu.com ([95.215.58.181]:49869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skN5O-0005KV-9s for 72704@debbugs.gnu.org; Sat, 31 Aug 2024 08:20:11 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1725106746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CC6jEt3aM65NXE3csuQwEkSDe+kB3v4HXjMXeEErV04=; b=R4kBX8p0D4f6S7MjIsAutqM1YB/eREdOjYdE3saNGFXX0infsrBN3I/u+bz8df9ixqIQs7 SgXB+xco5d6tmNv2tMvzOAj6i5vLzZMKa3SDVuF5g6OFY7fQdCdKKxpaH43a4zkOIHloDj sH8pfUaFQWqbp6szgY/dgt2Eo/aqNzA= In-Reply-To: <86bk19cagy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Aug 2024 12:23:09 +0300") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291012 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Joseph Turner >> Cc: Brian Green , rms@gnu.org, 72704@debbugs.gnu.org, >> juri@linkov.net >> Date: Sat, 24 Aug 2024 10:09:10 -0700 >> >> Eli Zaretskii writes: >> >> >> From: Brian Green >> >> Date: Sat, 24 Aug 2024 01:29:11 -0700 >> >> Cc: Eli Zaretskii , rms@gnu.org, 72704@debbugs.gnu.org, juri@linkov.net >> >> >> >> I submitted this "bug" report because I mis-interpreted the docstring, >> >> and because I was approaching this command with a preconceived idea >> >> about how it should work. I think Eli is right. I can't think of a >> >> good reason why I would need to stipulate a certain behavior before >> >> calling the command which I can already get at any point while the >> >> command is running. >> > >> > The doc string indeed could use some improvements, at least in stating >> > explicitly what happens in interactive usage and what only when called >> > from Lisp. >> >> See patch. Is the text wrapping acceptable? It looks too long in >> paragraphs.el but good in the *Help* buffer. > > Is this instead of the code change or in addition to it? Instead. > In any case, I think it would be better to say > > Noninteractively, if optional argument NO-QUERY is non-nil, make changes > without asking for confirmation. To achieve the same effect > interactively, press \\\\[automatic] at the first... Okay! With the attached patch, I'm content to close this issue. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Clarify-skipping-prompts-in-repunctuate-sentences-do.patch >From 723ca6c7537983d7979338ba4932ad54111b098d Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Sat, 31 Aug 2024 08:15:53 -0400 Subject: [PATCH] Clarify skipping prompts in repunctuate-sentences docstring * lisp/textmodes/paragraphs.el (repunctuate-sentences): Update docstring. bug#72704 Suggested-by: Eli Zaretskii --- lisp/textmodes/paragraphs.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/textmodes/paragraphs.el b/lisp/textmodes/paragraphs.el index be741e6517b..c2f75ef297b 100644 --- a/lisp/textmodes/paragraphs.el +++ b/lisp/textmodes/paragraphs.el @@ -545,9 +545,11 @@ repunctuate-sentences It works using `query-replace-regexp'. In Transient Mark mode, if the mark is active, operate on the contents of the region. Second and third arg START and END specify the region to operate on. -If optional argument NO-QUERY is non-nil, make changes without asking -for confirmation. You can use `repunctuate-sentences-filter' to add -filters to skip occurrences of spaces that don't need to be replaced." +Noninteractively, if optional argument NO-QUERY is non-nil, make changes +without asking for confirmation. You can achieve the same effect +interactively, press \\\\[automatic] at the first prompt to skip remaining prompts. +Use `repunctuate-sentences-filter' to add filters to skip occurrences of +spaces that don't need to be replaced." (declare (interactive-args (start (use-region-beginning)) (end (use-region-end)))) (interactive (list nil (use-region-beginning) (use-region-end))) -- 2.41.0 --=-=-=--