From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#73443: Fwd: bug#73443: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps Date: Tue, 24 Sep 2024 00:03:52 -0700 Message-ID: <871q19y1lz.fsf__45602.0041064889$1727161507$gmane$org@neverwas.me> References: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> <87tte5zvzl.fsf@neverwas.me> <87r0998tqe.fsf@trevarch.mail-host-address-is-not-set> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org, 73443@debbugs.gnu.org To: Trevor Arjeski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 24 09:04:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sszbW-00027s-Tr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Sep 2024 09:04:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sszbE-000128-BJ; Tue, 24 Sep 2024 03:04:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sszbC-00011t-RM for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2024 03:04:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sszbC-0001ID-Hg for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2024 03:04:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=8rdxf1+WWFMJ7BVvus6j9ZkIiWGnEEHHiA49zQaQBW4=; b=c5AJBOPt7Y9Ic10Lg3ctAQoED9hYvmbdUrYBJllcWFnXosX1VdGHOF232rK5P5fwTiDGQskJeEAncGi08HzWEplYJ4aURt7TE+LWbO11yl2y+biGY/23eNYuAtR4tQ5n5zUVvJrepqa0PFjMPDDqs1q5Op/TF/UKiCn8O1YOcWoR1qgHT3vS1upWowV3oa5TxrTZUuIgzdk/xaHEPYM+8wJEEAVlHSnCxRL4E/9D0B2xWRBTFy49HyxpCSyJGLwYff55iEhyRh1ufWdiUzx5QNZYw0LG0vFwr5t4brjtJDbf0PTgu8JfW5IJRH5Djtxo6jSHAbwQmm+hKcLGcZLBxA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sszba-0005NB-Gl for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2024 03:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2024 07:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73443 X-GNU-PR-Package: emacs Original-Received: via spool by 73443-submit@debbugs.gnu.org id=B73443.172716146520574 (code B ref 73443); Tue, 24 Sep 2024 07:05:02 +0000 Original-Received: (at 73443) by debbugs.gnu.org; 24 Sep 2024 07:04:25 +0000 Original-Received: from localhost ([127.0.0.1]:45151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sszay-0005Lm-Of for submit@debbugs.gnu.org; Tue, 24 Sep 2024 03:04:25 -0400 Original-Received: from mail-108-mta79.mxroute.com ([136.175.108.79]:39137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sszaw-0005Ld-KS for 73443@debbugs.gnu.org; Tue, 24 Sep 2024 03:04:23 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta79.mxroute.com (ZoneMTA) with ESMTPSA id 19222d805610003e01.001 for <73443@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 24 Sep 2024 07:03:55 +0000 X-Zone-Loop: a451cc90a3d2b86de2d55c0d3b7fd36bc30f1ce3d511 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8rdxf1+WWFMJ7BVvus6j9ZkIiWGnEEHHiA49zQaQBW4=; b=ajfQG+Zf5v+wQ9hJ89zXeI2pwx 3tL8xvev4iTwJZv6zfau+K+WUgj4ITGo3oeFpOK6OpXrnnfex2ZPHOiSeju4IC3TFJ9uUq7dk0vRT xUn0Io5mcOpHSgJcp2fpCB6jDiL/iy7l+qGB5NAnkvw9SOQ8LHMiK2tGeDkYz615INF4Py7270J86 TkEDTua15zVyK8ZbCoxSabYLBGLT6cZg5K3Y/MiwoTOdiYpRw6I2VqG8BfxkIE840JjFSQGhoEJ3s 6tC9QiRnB7kl9Iu9/WYaOp7L1x28cH1N6EV66+CLBTFJN+Z4lpkMl4kOX4M/F9h1VzzuM8bHCNz0X zkFvUdPA==; In-Reply-To: (Trevor Arjeski's message of "Tue, 24 Sep 2024 09:53:29 +0300") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292308 Archived-At: Trevor Arjeski writes: > "J.P." writes: > >> Complicating things slightly is this bit from the subject line: >> >> "29.4; ERC 5.6.1-git" >> > The version output with your snippet: 5.6.1snapshot0.20240813.11230 OK, that's what I get when I install straight.el from scratch. So at least we're synced. > > Agreed. I don't even really want to begin debugging this. Perhaps we > should consider the issue moot unless verifiable on Emacs 30+ or master. You could start by "bisecting" the non-ERC parts of your config or the non-ERC modes listed in the gathered facts from your initial report (default stuff commented out): // erc-ring-mode: t // erc-nicks-mode: t // config // erc-netsplit-mode: t // erc-menu-mode: t // erc-list-mode: t // erc-imenu-mode: t // erc-pcomplete-mode: t // erc-button--phantom-users-mode: t // erc-button-mode: t // erc-fill-mode: t // erc-stamp-mode: t // erc-autojoin-mode: t // erc-irccontrols-mode: t // erc-move-to-prompt-mode: t // erc-readonly-mode: t // erc-scrolltobottom-mode: t // config // erc-spelling-mode: t // config // flyspell-mode: t // config (spell module) // erc-track-mode: t // erc-track-minor-mode: t // erc-match-mode: t // erc-networks-mode: t diff-hl-flydiff-mode: t global-diff-hl-mode: t electric-pair-mode: t apheleia-global-mode: t global-treesit-auto-mode: t corfu-popupinfo-mode: t global-corfu-mode: t corfu-mode: t marginalia-mode: t vertico-mode: t which-key-mode: t global-ligature-mode: t ligature-mode: t global-auto-revert-mode: t global-display-line-numbers-mode: t desktop-save-mode: t recentf-mode: t save-place-mode: t // straight-use-package-mode: t // config // straight-package-neutering-mode: t // config override-global-mode: t // global-eldoc-mode: t // show-paren-mode: t // electric-indent-mode: t // mouse-wheel-mode: t // file-name-shadow-mode: t // global-font-lock-mode: t // font-lock-mode: t // blink-cursor-mode: t column-number-mode: t // line-number-mode: t // transient-mark-mode: t // auto-composition-mode: t // auto-encryption-mode: t // auto-compression-mode: t So, essentially, you'd just be adding like half of these to the base config from my previous reply, e.g., (use-package diff-hl ...) ; where "..." means "your config details" (use-package elec-pair :straight nil :init (electric-pair-mode +1)) (use-package apheleia ...) ;; [...] (use-package vertico ...) And if the bug is still present, remove half of those, and so on. But if it's absent, switch to the other half and test again. Let me know if that doesn't make sense. (And apologies if you're already familiar with this method.) > >> FWIW, using the above setup, I don't notice the behavior described nor >> any difference in the mode line with `erc-insert-timestamp-function' set >> to 'erc-insert-timestamp-right' or its default. > > I was not able to reproduce the issue either with your provided config > using 'erc-insert-timestamp-left (also needed to turn on erc-track-mode). FYI, you actually don't _need_ to explicitly activate any minor modes for modules that appear in `erc-modules', which `track' (i.e., `erc-track-mode') does by default. I know the ";;; Commentary" front matter atop ERC's libraries makes it seem otherwise, but that's because they're ancient and were never updated. Sorry about that (good first issue, though). So, yeah, rule of thumb: if `erc-modules' contains some module `foo', you almost never need (erc-foo-mode +1) in your config, at least not for built-in modules. That said, doing so is superfluous and basically benign. > > Thanks for looking into this. No problem!