* bug#74773: [PATCH] Elaborate doc string for rcirc-next-active-buffer
@ 2024-12-10 19:20 Scott Bell via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 12:21 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Scott Bell via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-12-10 19:20 UTC (permalink / raw)
To: 74773
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
I found the current behavior of rcirc-next-active-buffer surprising in
the case where there is no activity, so I thought it could be described
in the doc string.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch file --]
[-- Type: text/x-patch, Size: 906 bytes --]
From b5a3f93c006316d53139bbd308afbf4c70c89289 Mon Sep 17 00:00:00 2001
From: Scott Bell <sctb@me.com>
Date: Tue, 10 Dec 2024 12:02:54 -0700
Subject: [PATCH] ; * lisp/net/rcirc.el (rcirc-next-active-buffer): Doc string
---
lisp/net/rcirc.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index c41e2ec153f..33e4008fc0b 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -2448,7 +2448,8 @@ rcirc-bury-buffers
(defun rcirc-next-active-buffer (arg)
"Switch to the next rcirc buffer with activity.
-With prefix ARG, go to the next low priority buffer with activity."
+With prefix ARG, go to the next low priority buffer with activity.
+When there are no buffers with activity, bury all rcirc buffers."
(interactive "P")
(let* ((pair (rcirc-split-activity rcirc-activity))
(lopri (car pair))
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#74773: [PATCH] Elaborate doc string for rcirc-next-active-buffer
2024-12-10 19:20 bug#74773: [PATCH] Elaborate doc string for rcirc-next-active-buffer Scott Bell via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-12-11 12:21 ` Eli Zaretskii
2024-12-11 13:37 ` Leo Liu
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2024-12-11 12:21 UTC (permalink / raw)
To: Scott Bell, Leo Liu, Philip Kaludercic; +Cc: 74773
> Date: Tue, 10 Dec 2024 12:20:04 -0700
> From: Scott Bell via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> I found the current behavior of rcirc-next-active-buffer surprising in
> the case where there is no activity, so I thought it could be described
> in the doc string.
Leo and Philip, is this okay to install?
> >From b5a3f93c006316d53139bbd308afbf4c70c89289 Mon Sep 17 00:00:00 2001
> From: Scott Bell <sctb@me.com>
> Date: Tue, 10 Dec 2024 12:02:54 -0700
> Subject: [PATCH] ; * lisp/net/rcirc.el (rcirc-next-active-buffer): Doc string
>
> ---
> lisp/net/rcirc.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
> index c41e2ec153f..33e4008fc0b 100644
> --- a/lisp/net/rcirc.el
> +++ b/lisp/net/rcirc.el
> @@ -2448,7 +2448,8 @@ rcirc-bury-buffers
>
> (defun rcirc-next-active-buffer (arg)
> "Switch to the next rcirc buffer with activity.
> -With prefix ARG, go to the next low priority buffer with activity."
> +With prefix ARG, go to the next low priority buffer with activity.
> +When there are no buffers with activity, bury all rcirc buffers."
> (interactive "P")
> (let* ((pair (rcirc-split-activity rcirc-activity))
> (lopri (car pair))
> --
> 2.39.5 (Apple Git-154)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#74773: [PATCH] Elaborate doc string for rcirc-next-active-buffer
2024-12-11 12:21 ` Eli Zaretskii
@ 2024-12-11 13:37 ` Leo Liu
2024-12-11 16:31 ` Philip Kaludercic
0 siblings, 1 reply; 4+ messages in thread
From: Leo Liu @ 2024-12-11 13:37 UTC (permalink / raw)
To: Zaretskii Eli; +Cc: Bell Scott, Kaludercic Philip, 74773
> On 11 Dec 2024, at 20:21, Eli Zaretskii <eliz@gnu.org> wrote:
>
>
>>
>> Date: Tue, 10 Dec 2024 12:20:04 -0700
>> From: Scott Bell via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> I found the current behavior of rcirc-next-active-buffer surprising in
>> the case where there is no activity, so I thought it could be described
>> in the doc string.
>
> Leo and Philip, is this okay to install?
After checking all irc buffers with activity, the next rcirc-next-active-buffer returns you back to the buffer where your work is ie non irc buffers.
So the patch doesn’t add much though harmless.
— Leo
>
>>> From b5a3f93c006316d53139bbd308afbf4c70c89289 Mon Sep 17 00:00:00 2001
>> From: Scott Bell <sctb@me.com>
>> Date: Tue, 10 Dec 2024 12:02:54 -0700
>> Subject: [PATCH] ; * lisp/net/rcirc.el (rcirc-next-active-buffer): Doc string
>>
>> ---
>> lisp/net/rcirc.el | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
>> index c41e2ec153f..33e4008fc0b 100644
>> --- a/lisp/net/rcirc.el
>> +++ b/lisp/net/rcirc.el
>> @@ -2448,7 +2448,8 @@ rcirc-bury-buffers
>>
>> (defun rcirc-next-active-buffer (arg)
>> "Switch to the next rcirc buffer with activity.
>> -With prefix ARG, go to the next low priority buffer with activity."
>> +With prefix ARG, go to the next low priority buffer with activity.
>> +When there are no buffers with activity, bury all rcirc buffers."
>> (interactive "P")
>> (let* ((pair (rcirc-split-activity rcirc-activity))
>> (lopri (car pair))
>> --
>> 2.39.5 (Apple Git-154)
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#74773: [PATCH] Elaborate doc string for rcirc-next-active-buffer
2024-12-11 13:37 ` Leo Liu
@ 2024-12-11 16:31 ` Philip Kaludercic
0 siblings, 0 replies; 4+ messages in thread
From: Philip Kaludercic @ 2024-12-11 16:31 UTC (permalink / raw)
To: Leo Liu; +Cc: Bell Scott, Zaretskii Eli, 74773
Leo Liu <sdl.web@gmail.com> writes:
>> On 11 Dec 2024, at 20:21, Eli Zaretskii <eliz@gnu.org> wrote:
>>
>>
>>>
>>> Date: Tue, 10 Dec 2024 12:20:04 -0700
>>> From: Scott Bell via "Bug reports for GNU Emacs,
>>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>>
>>> I found the current behavior of rcirc-next-active-buffer surprising in
>>> the case where there is no activity, so I thought it could be described
>>> in the doc string.
>>
>> Leo and Philip, is this okay to install?
>
> After checking all irc buffers with activity, the next rcirc-next-active-buffer returns you back to the buffer where your work is ie non irc buffers.
>
> So the patch doesn’t add much though harmless.
1+
> — Leo
>
>>
>>>> From b5a3f93c006316d53139bbd308afbf4c70c89289 Mon Sep 17 00:00:00 2001
>>> From: Scott Bell <sctb@me.com>
>>> Date: Tue, 10 Dec 2024 12:02:54 -0700
>>> Subject: [PATCH] ; * lisp/net/rcirc.el (rcirc-next-active-buffer): Doc string
>>>
>>> ---
>>> lisp/net/rcirc.el | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
>>> index c41e2ec153f..33e4008fc0b 100644
>>> --- a/lisp/net/rcirc.el
>>> +++ b/lisp/net/rcirc.el
>>> @@ -2448,7 +2448,8 @@ rcirc-bury-buffers
>>>
>>> (defun rcirc-next-active-buffer (arg)
>>> "Switch to the next rcirc buffer with activity.
>>> -With prefix ARG, go to the next low priority buffer with activity."
>>> +With prefix ARG, go to the next low priority buffer with activity.
>>> +When there are no buffers with activity, bury all rcirc buffers."
>>> (interactive "P")
>>> (let* ((pair (rcirc-split-activity rcirc-activity))
>>> (lopri (car pair))
>>> --
>>> 2.39.5 (Apple Git-154)
>>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-11 16:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-10 19:20 bug#74773: [PATCH] Elaborate doc string for rcirc-next-active-buffer Scott Bell via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 12:21 ` Eli Zaretskii
2024-12-11 13:37 ` Leo Liu
2024-12-11 16:31 ` Philip Kaludercic
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).