unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Leo Liu <sdl.web@gmail.com>
Cc: Bell Scott <sctb@me.com>, Zaretskii Eli <eliz@gnu.org>,
	74773@debbugs.gnu.org
Subject: bug#74773: [PATCH] Elaborate doc string for rcirc-next-active-buffer
Date: Wed, 11 Dec 2024 16:31:56 +0000	[thread overview]
Message-ID: <871pyexjsz.fsf@posteo.net> (raw)
In-Reply-To: <67CD84A6-0BEE-4C6E-8F12-D2181FB74B95@gmail.com> (Leo Liu's message of "Wed, 11 Dec 2024 21:37:25 +0800")

Leo Liu <sdl.web@gmail.com> writes:

>> On 11 Dec 2024, at 20:21, Eli Zaretskii <eliz@gnu.org> wrote:
>> 
>> 
>>> 
>>> Date: Tue, 10 Dec 2024 12:20:04 -0700
>>> From:  Scott Bell via "Bug reports for GNU Emacs,
>>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>> 
>>> I found the current behavior of rcirc-next-active-buffer surprising in
>>> the case where there is no activity, so I thought it could be described
>>> in the doc string.
>> 
>> Leo and Philip, is this okay to install?
>
> After checking all irc buffers with activity, the next rcirc-next-active-buffer returns you back to the buffer where your work is ie non irc buffers.
>
> So the patch doesn’t add much though harmless.

1+

> — Leo
>
>> 
>>>> From b5a3f93c006316d53139bbd308afbf4c70c89289 Mon Sep 17 00:00:00 2001
>>> From: Scott Bell <sctb@me.com>
>>> Date: Tue, 10 Dec 2024 12:02:54 -0700
>>> Subject: [PATCH] ; * lisp/net/rcirc.el (rcirc-next-active-buffer): Doc string
>>> 
>>> ---
>>> lisp/net/rcirc.el | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
>>> index c41e2ec153f..33e4008fc0b 100644
>>> --- a/lisp/net/rcirc.el
>>> +++ b/lisp/net/rcirc.el
>>> @@ -2448,7 +2448,8 @@ rcirc-bury-buffers
>>> 
>>> (defun rcirc-next-active-buffer (arg)
>>>   "Switch to the next rcirc buffer with activity.
>>> -With prefix ARG, go to the next low priority buffer with activity."
>>> +With prefix ARG, go to the next low priority buffer with activity.
>>> +When there are no buffers with activity, bury all rcirc buffers."
>>>   (interactive "P")
>>>   (let* ((pair (rcirc-split-activity rcirc-activity))
>>>          (lopri (car pair))
>>> --
>>> 2.39.5 (Apple Git-154)
>>> 





      reply	other threads:[~2024-12-11 16:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 19:20 bug#74773: [PATCH] Elaborate doc string for rcirc-next-active-buffer Scott Bell via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 12:21 ` Eli Zaretskii
2024-12-11 13:37   ` Leo Liu
2024-12-11 16:31     ` Philip Kaludercic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pyexjsz.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=74773@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=sctb@me.com \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).