From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#74781: [PATCH] Add `browse-url-qutebrowser' Date: Wed, 11 Dec 2024 16:44:27 +0100 Message-ID: <871pye5in8.fsf@gmail.com> References: <87msh21z0i.fsf@daniel-mendler.de> <865xnq4720.fsf@gnu.org> <87pllyuuco.fsf@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5557"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 74781@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 16:46:48 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLOvH-0001HW-Ko for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 16:46:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLOuu-0003Bi-4W; Wed, 11 Dec 2024 10:46:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLOua-0003Ax-Q3 for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 10:46:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLOuY-0002o9-8t for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 10:46:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=XTzoGMPnHqdonrWEfsrxqPzA6H6hHKsU3p2Bm9N8unA=; b=NLD9sgpI0adonqGHAsKxB77LnvaARGu9LRbW8AqVMHTbyVDKc0xdpAJ2rqDWUx70EYfZ3msG+2giQPouqDNms+9kQfMRAA8HedrS3BhoKpXaiPNF/c05Mg4IOsUe+OlhYq4aVumYQbxJKn/CBsAZJFbb0lQQx57+d7lwURsAWJVpfzq99pfkr8+dogZbPyiNB8k6974kROUI2l8wfw4TD9zib9Nk0XoL474g6prZhD5M8n8wLGP7Y+cZqOMt+aQtmAufQABfivOxTsYQFMTahH4ykIiVtb+sCUu6ConxncwYjyCpGFVydANuecH0i6A84HvyKvOTG7gSRQaS2Oa8rg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLOuY-0008JJ-2G for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 10:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 15:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74781-submit@debbugs.gnu.org id=B74781.173393193231882 (code B ref 74781); Wed, 11 Dec 2024 15:46:02 +0000 Original-Received: (at 74781) by debbugs.gnu.org; 11 Dec 2024 15:45:32 +0000 Original-Received: from localhost ([127.0.0.1]:35787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLOu4-0008I8-4C for submit@debbugs.gnu.org; Wed, 11 Dec 2024 10:45:32 -0500 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:49638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLOu1-0008Ht-NZ for 74781@debbugs.gnu.org; Wed, 11 Dec 2024 10:45:30 -0500 Original-Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4361e89b6daso5250215e9.3 for <74781@debbugs.gnu.org>; Wed, 11 Dec 2024 07:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733931869; x=1734536669; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=XTzoGMPnHqdonrWEfsrxqPzA6H6hHKsU3p2Bm9N8unA=; b=CG8lXJi/lMdnJ5eTUSMwFax1MxX4szciNLrT5TBMqL1AnygCenlkFg0nob6Xq1x3dz 4j4HNRN5+irRtJElgRn8dKlGRhg4hAGoiWnSNHZBl3uiRHZm4EhiWNLsnQR+Tx1aJe53 pd0P57DZAeFGfSwKnZVSPkg2RUFmvghNH8cvXFLX8HseaxNZr5maMz+oqurY9gWUdWnS DIkz2qj4X2BLfHz9R1YKuoa8RSSMeLt+b9lh00PIMn8sZUDoD5OdlbanCifiV8TOPlVJ H8sCH6WdlAHhefvTzgm+Or7B533ZU52UI9bWdLXhrklG1XRgzzK/SPIFH9uiUD9N3q+x kC2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733931869; x=1734536669; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XTzoGMPnHqdonrWEfsrxqPzA6H6hHKsU3p2Bm9N8unA=; b=XyiKoG+S4W/8okb+ngiNJxMMa0Q9/JjJWJ9igw17HnNqjbpFVUgc7+a8anPnCBbxX+ 1MTzOwRbvxRB6G5RKQPJFPTFx5h5hoZtXJn1z5duQTt6xrc6zxV2jI2XoWMXPMMq0SG0 WF2T3WVpkiVz0w+812yGireew+cf3jQwIoD5B2faKvOhewXA9JVetnu+pP00/V6E+IYm jLLV04YhOdEFzUuQf7lDAagDrpOYfDT102YJ+QvAfOXTHbRDrEoR/egmvNLKcX0uFAmn c5pizQHs0LvZ0ASNlZ20emGchNZ5belvFUren4LP+qwOSwZk5jN7I7n30Iz3c8W+kOUo qN0g== X-Forwarded-Encrypted: i=1; AJvYcCXep3wW6i7WlT68x3pueJ/HAv9y82H0/1qcIwbdNFzWPyMjgdszpMf3RG9qa+IHWmxmyrgyVw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxutMpLYc+GOcrrLpeO6xxCSY+L8X/PBiL+MRXUs/P4OQizRRFp 6FLj+xHC0JKuWdWRbYx07RjFcCRKZ0QmhvuWq4oMUUbL3cPIzEjAfcRE7g== X-Gm-Gg: ASbGncsLCFi/iAicDw+HimqtnKSa2cTFgIA+mr0ng0fpfOiJXZFHcu2Gf7bwuQx52kc 0sPPUMZcscbYOTE1dcjQqjmFw6PeR+isVnUEJ3OzWrhaoWtIDGQOcCay05HaSevmt1xKSTE2uPE ScSRZFWHvLwC8lR42mLh4IMycZuuNu9caMceq2oXrUJhkbn2VG/R+BwcCBPH+wr4GYyhF4o6TYX r1e93Fyhj5cfH5PtzXawSeR0Pe+xwfxygtL+KlMnQ== X-Google-Smtp-Source: AGHT+IFDDZGhozjdWvliV9iFIWJfKfT8q7EQbYimHNhGdwRqXtyU6t47EhT9EBDCsrtst84bq7h5Ww== X-Received: by 2002:a05:600c:468a:b0:434:f0df:a14 with SMTP id 5b1f17b1804b1-4361c34623dmr28251025e9.2.1733931868433; Wed, 11 Dec 2024 07:44:28 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb51:c52c:e130:63af:d25d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436229d1824sm467125e9.18.2024.12.11.07.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2024 07:44:27 -0800 (PST) In-Reply-To: <87pllyuuco.fsf@daniel-mendler.de> (Daniel Mendler via's message of "Wed, 11 Dec 2024 16:12:23 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296841 Archived-At: >>>>> On Wed, 11 Dec 2024 16:12:23 +0100, Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" said: Daniel> Hello Eli, Daniel> thanks. I added the version tags, the NEWS entry, improved the Daniel> docstrings and use `xdg-runtime-dir' now. See the updated patch Daniel> attached to this mail. >>> + (sock (and dir (expand-file-name >>> + (format "qutebrowser/ipc-%s" (md5 (user-login-name))) >>> + dir)))) >> >> I think Qutebrowser is available on Windows, where we don't (yet) >> support local sockets. So I think there should be some kind of test >> for running on Windows, and falling back to alternatives. Daniel> On Windows, the socket won't be there, and the new Qutebrowser window Daniel> will be opened by the newly executed Qutebrowser process via Daniel> `call-process'. This will work but is unfortunately slower. And it will check for the socket for every URL. Could you perhaps test whether to use the socket or not just once, and then use the appropriate call? Robert --