From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#74735: 31.0.50; Commit 986621ae1ff4d3cfad31adb20216f1f71ce0747c broke org-ql Date: Sat, 14 Dec 2024 07:13:23 +0530 Message-ID: <871pyb11l0.fsf@gmail.com> References: <87r06i8m8v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2944"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74735@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 14 02:45:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMHDi-0000aW-3y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Dec 2024 02:45:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMHDO-0002Mg-Nd; Fri, 13 Dec 2024 20:45:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMHDL-0002KT-1s for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2024 20:45:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMHDK-0001I0-KC for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2024 20:45:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=whKW4jWl84qXOX5bLCSSvccxvVbdpOCORD02ExQeKKA=; b=g4XhJQ5TFfA3b50yPeITPHUAz+RK3PFYiq0I6r98HgAt9+KEjQwZv+fy8/olGbQ+Zo/YIIe7xshf318iRuafx1A2vulSCYpTL8547MvJ2XWKMIk52S+YtTF6q7qPjxafC73Iv1Zcl78dMm7z92hgWUkzwbtYEgrtg4mcDv880YK0LHX68dFz43RNOrNGCBEwC/ttLbQROvrXOK7WosRW6uxLNjXz1lkJ3FxF8bUFiFQVcmrJGuy8Y3/h2Yar7M67vxcSGLhyseFPiyzd4K1xe7SV0yXEn4qBspLsPU5UmwvkhTatpppcOE6BmcIAEPwz1q9gwI4mron7jPsw3V7b2A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tMHDJ-0001Ir-Tp for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2024 20:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Dec 2024 01:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74735 X-GNU-PR-Package: emacs Original-Received: via spool by 74735-submit@debbugs.gnu.org id=B74735.17341406744946 (code B ref 74735); Sat, 14 Dec 2024 01:45:01 +0000 Original-Received: (at 74735) by debbugs.gnu.org; 14 Dec 2024 01:44:34 +0000 Original-Received: from localhost ([127.0.0.1]:44888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMHCr-0001Hh-K9 for submit@debbugs.gnu.org; Fri, 13 Dec 2024 20:44:33 -0500 Original-Received: from mail-pl1-f195.google.com ([209.85.214.195]:56370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMHCn-0001HW-NZ for 74735@debbugs.gnu.org; Fri, 13 Dec 2024 20:44:32 -0500 Original-Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2163b0c09afso21763265ad.0 for <74735@debbugs.gnu.org>; Fri, 13 Dec 2024 17:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734140609; x=1734745409; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=whKW4jWl84qXOX5bLCSSvccxvVbdpOCORD02ExQeKKA=; b=RRYMVsbZk3CEAeiCvwA7ZVUyN43jPNTRXI8VmfSBftipxTyXWSBJrdy9dNrQVJdScG C8bYM9mjbGYIlCi61+wLl1vmp6xzl0Q3XSxqSnh9ZRVEh/6OfcskYGb/IPa1+m1hhEs4 wRX8JvprNfqCEBFVRMe40bFuQt8hRArrlYNmnekjRSxeccorLMzKYuNGVqtNkQIHkjI2 lgu2yDMIK7YNTuNRQtHVrZFXXctdQSP2M6X4Xw5clRU9nZBy73WcemIYM7hyf27ymPVB V9107Yb+qg+ILQOyUjDCVysLlZ8gKLkZEcjxr/mDHMF23GizKaraTvimNDuqEW136zg2 yfXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734140609; x=1734745409; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=whKW4jWl84qXOX5bLCSSvccxvVbdpOCORD02ExQeKKA=; b=t0hAY0HbJWvZs2hsqCU4zGLa2xbM9+FBqUN8ShOKLdy8MGWZ25r1Gpz8umGSbFp0fG 2fL+7JD06wDFZN9VDZvRLhrqft6E0tiwwDsIEyhUpJMog16DLYnPDAirFiRfImg9bJud 3e3TWl3rKd0Moi5NVqVSPxBhoXGLqepS+wilhGLgqACTrzWYj1haAPO0kKf7PamWKy1c 2QIVMy0+jqUxAuqquttNPmGkrJUYcxK/Ym41loKQyJx3mukPo5qlPk2DF0ndxRDGswAD +EweQCltQUJjM8f+rLPwgsLWPIrNtezLKvaYmKHo6RVHqhyNkImybahZk4RgHXW84OyD 7i9g== X-Gm-Message-State: AOJu0YzjG5fLWzFmNIzbLPhLFUgSWS0fmDVxY+cg4wBJzBudMVBguBVn 0hQ9WaloSfmsEAD1oc2Rfp2zr/dVANFNy1DSdzXC677i9IT7qpZk X-Gm-Gg: ASbGnct2HkB5rLMgHyE6GNmZ6HNTDIIGbDlm+xdvYw90DFE1Np22mPZPL+BYovtlMOr /NFczgKlCusZ6suXzK0MbtAa1I+vEIywX72DapkORot/cwHaSmWW4DJ1GggwvrVKLDY6K5fn6cP B515mNCrXapFz4mNf/13T/ZxEo3PYud8uzUDne+KuhppEtlj6ZAv2RjU/o5ttLhMByUsDVfdLhj Ll3Zi/r4oScpVj4LMAAS8cdnYvBJVz3o6rQw/5FBxABzG4i3lkKVA== X-Google-Smtp-Source: AGHT+IEeCLJk2tCkeiHjPsyAHS2euarB96h2Yl0hZNJVxqZJ7jHO4vrQQrr5XMJ3HDsBqik6BspP8Q== X-Received: by 2002:a17:902:f688:b0:216:4cc2:b1e0 with SMTP id d9443c01a7336-218929d71f7mr54393395ad.20.1734140608550; Fri, 13 Dec 2024 17:43:28 -0800 (PST) Original-Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e501c5sm3780585ad.135.2024.12.13.17.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 17:43:27 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Fri, 13 Dec 2024 17:21:07 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297003 Archived-At: [=E0=AE=B5=E0=AF=86=E0=AE=B3=E0=AF=8D=E0=AE=B3=E0=AE=BF =E0=AE=9F=E0=AE=BF= =E0=AE=9A=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 13, 2024] Stefan Mon= nier wrote: >> The recent change you made in >> >> commit 986621ae1ff4d3cfad31adb20216f1f71ce0747c >> Author: Stefan Monnier >> Date: Tue Nov 12 23:12:07 2024 -0500 >> >> (with-peg-rules): Build proper `peg-function`s >> >> * lisp/progmodes/peg.el (with-peg-rules): Use the new (FUNC EXP) >> feature in `cl-labels`. >> >> broke org-ql's PEG parser. I tried to reproduce it with the number >> parser example given in the Elisp Info manual but failed. With the >> above change, I get an assertion error when I try to use org-ql-find: >> >> Debugger entered--Lisp error: (cl-assertion-failed (lexical-binding nil)) > > Thanks. Until this is fixed on `master`, the patch below will fix > `org-ql` to use lexical-binding for that code (like it already does for > all the rest of the code). Thanks! I tried this exact change but it still erred. Now, the error went away. I guess I did not re-eval the relevant functions properly. > [ It also removes a NUL byte from the file which caused some tools to > treat it as a binary file. ] Thanks for catching this! I always wondered why the modeline did not say 'U' for the encoding. > diff --git a/org-ql.el b/org-ql.el > index f3b7715..654da49 100644 > --- a/org-ql.el > +++ b/org-ql.el > @@ -863,7 +863,7 @@ respectively." > (zero-or-more (not (any "\n\":")))) > (zero-or-more (not (any "\n\":"))))) > (group (zero-or-more (not (any "\n")))) "\n" > - (63 (group (*\? (not (any "."))) "\n")) > + (63 (group (*\? (not (any "\0"))) "\n")) > (zero-or-more (any " ")) > "#+end_src") > t)) > @@ -1003,7 +1003,8 @@ value of `org-ql-predicates')." > (peg-run (peg ,(caar pexs)) > (lambda (failures) > (when org-ql-signal-= peg-failure > - (peg-signal-failur= e failures))))))))) > + (peg-signal-failur= e failures))))) > + t)))) > (pcase parsed-sexp > (`(,one-predicate) one-predicate) > (`(,_ . ,_) (cons boolean (reverse parsed-sexp= ))) Shall I notify Adam of this change?