bug#24651: 25.1; frame-inherited-parameters only partially works

[martin rudalics <rudalics@gmx.at>]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

 > Clearly, a `sit-for` is undesirable, so if we can avoid it we should.
 > Setting the params before creating the frame also has the advantage of
 > avoiding a visible resize.

And no 100% untested patch?  The attached should do it but I think has
the some conceptual flaw as the old behavior: When a val is nil, it
won't override a default parameter whose value is non-nil.  But I never
figured out what inherited parameters are useful for in the first place
so maybe this is of no importance.

martin

[-- Attachment #2: frame-inherited-parameters.diff --]
[-- Type: text/x-patch, Size: 1478 bytes --]

diff --git a/lisp/frame.el b/lisp/frame.el
index 772ba3d8c4..948c782328 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -864,7 +864,6 @@ make-frame
                   (error "Don't know how to interpret display %S"
                          display)))
              (t window-system)))
-	 (oldframe (selected-frame))
 	 (params parameters)
 	 frame child-frame)

@@ -882,8 +881,12 @@ make-frame
     (dolist (p default-frame-alist)
       (unless (assq (car p) params)
 	(push p params)))
-
-;;     (setq frame-size-history '(1000))
+    ;; Add parameters from `frame-inherited-parameters' unless they are
+    ;; overridden by explicit parameters.
+    (dolist (param frame-inherited-parameters)
+      (unless (assq param parameters)
+        (let ((val (frame-parameter nil param)))
+          (when val (push (cons param val) params)))))

     (when (eq (cdr (or (assq 'minibuffer params) '(minibuffer . t)))
               'child-frame)
@@ -916,12 +919,6 @@ make-frame
          frame 'minibuffer (frame-root-window child-frame))))

     (normal-erase-is-backspace-setup-frame frame)
-    ;; Inherit original frame's parameters unless they are overridden
-    ;; by explicit parameters.
-    (dolist (param frame-inherited-parameters)
-      (unless (assq param parameters)
-        (let ((val (frame-parameter oldframe param)))
-          (when val (set-frame-parameter frame param val)))))

     (when (numberp (car frame-size-history))
       (setq frame-size-history