From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#18788: 24.4; vc-git-working-revision vs mode-line gives error Date: Sun, 14 Dec 2014 13:15:18 +0200 Message-ID: <86zjaqo52x.fsf@yandex.ru> References: <87wq7sfqtt.fsf@fsfe.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1418555789 6035 80.91.229.3 (14 Dec 2014 11:16:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Dec 2014 11:16:29 +0000 (UTC) Cc: 18788@debbugs.gnu.org To: Kevin Brubeck Unhammer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 14 12:16:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y079w-0001au-6v for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Dec 2014 12:16:20 +0100 Original-Received: from localhost ([::1]:35620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y079v-0002Tb-MM for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Dec 2014 06:16:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y079m-0002TE-B3 for bug-gnu-emacs@gnu.org; Sun, 14 Dec 2014 06:16:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y079e-0002gK-4U for bug-gnu-emacs@gnu.org; Sun, 14 Dec 2014 06:16:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y079e-0002gG-15 for bug-gnu-emacs@gnu.org; Sun, 14 Dec 2014 06:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y079d-0000Dh-LC for bug-gnu-emacs@gnu.org; Sun, 14 Dec 2014 06:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Dec 2014 11:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18788 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18788-submit@debbugs.gnu.org id=B18788.1418555730804 (code B ref 18788); Sun, 14 Dec 2014 11:16:01 +0000 Original-Received: (at 18788) by debbugs.gnu.org; 14 Dec 2014 11:15:30 +0000 Original-Received: from localhost ([127.0.0.1]:45247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0798-0000Ct-Gq for submit@debbugs.gnu.org; Sun, 14 Dec 2014 06:15:30 -0500 Original-Received: from mail-wg0-f44.google.com ([74.125.82.44]:60978) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0796-0000Cg-Lo for 18788@debbugs.gnu.org; Sun, 14 Dec 2014 06:15:29 -0500 Original-Received: by mail-wg0-f44.google.com with SMTP id b13so12424341wgh.3 for <18788@debbugs.gnu.org>; Sun, 14 Dec 2014 03:15:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=rv0JSVvLymvKlZuhgQ9UqP/45enzezc4LeXeWoL+/js=; b=Dqq/GdxwWoTzUhxHY3f44iPbWnR8WnnmKabWFPq0uGnCpCazj9XXOzQpZdGozT5SoY 22aJvewwqN8lwBqVr6jqRdJ0MgzM/HMSjsh4uvSaxUPNNtUwpzIHaJxCQsY+DNkwE1Hk Ps3fShe083dvtz3Wrjlrf18oBANNXwraMpSAkFSnwdypLQoPh+B0ekyJs6DcSniyfa0W pIQBwQEyNGLZBFt/87VK9AWnbXGM8yDCKb5BjPJsrFB5Y0/WKnAJdenAxaRvfIfmMAkZ 2mokUS7Xk3+fHLnSKdSjIaAoVpYVUxwnGYoi9xDN91tiINN57/PMHU+8LoWIr/iEZKNV h/nA== X-Received: by 10.180.90.81 with SMTP id bu17mr22242082wib.23.1418555722790; Sun, 14 Dec 2014 03:15:22 -0800 (PST) Original-Received: from axl ([82.102.93.58]) by mx.google.com with ESMTPSA id wb9sm9013756wic.20.2014.12.14.03.15.21 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 14 Dec 2014 03:15:22 -0800 (PST) In-Reply-To: <87wq7sfqtt.fsf@fsfe.org> (Kevin Brubeck Unhammer's message of "Wed, 22 Oct 2014 10:31:42 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.51 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97313 Archived-At: Kevin Brubeck Unhammer writes: > Whenever I try to save a git-registered file under emacs 24.4, I get > > apply: Args out of range: #("Git@" 0 4 (help-echo "Locally added > file under the Git version control system")), 0, 7 I don't see that. Does that happen in a bare session (started with `emacs -Q')? Is there anything special about the repository, or its current local state? > The function vc-git-mode-line-string tries to get the revision using > vc-working-revision, which returns nil. Instead of checking the `rev' > variable for nil, it checks `detached', before calling substring. It > should probably do > > (if (and detached rev) > (substring =E2=80=A6)=20 > =E2=80=A6) > > instead. I don't know why vc-working-revision returns nil though > (there's a whole lot of indirection to dig through there). Does (vc-git-working-revision buffer-file-name) return nil in the same buff= er?