From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Tue, 28 Dec 2021 20:32:22 +0200 Organization: LINKOV.NET Message-ID: <86zgokpoll.fsf@mail.linkov.net> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11109"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 51809@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 28 20:04:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2Hlb-0002kJ-Fl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 20:04:11 +0100 Original-Received: from localhost ([::1]:53672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2HlZ-0001LE-P8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 14:04:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2HlS-0001Kq-La for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2HlS-0007Au-Br for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2HlS-0008BC-2Y for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Dec 2021 19:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.164071820731390 (code B ref 51809); Tue, 28 Dec 2021 19:04:02 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 28 Dec 2021 19:03:27 +0000 Original-Received: from localhost ([127.0.0.1]:47407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Hks-0008AD-Qm for submit@debbugs.gnu.org; Tue, 28 Dec 2021 14:03:27 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:38999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Hkq-00089y-P5 for 51809@debbugs.gnu.org; Tue, 28 Dec 2021 14:03:25 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 8C217E0008; Tue, 28 Dec 2021 19:03:17 +0000 (UTC) In-Reply-To: <87r19zs662.fsf@gmail.com> (Matthias Meulien's message of "Sun, 26 Dec 2021 17:05:25 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223270 Archived-At: > @@ -353,7 +353,9 @@ outline-mode > + (add-hook 'change-major-mode-hook #'outline-show-all nil t) > + (add-hook 'hack-local-variables-hook > + #'outline-apply-default-state)) > > @@ -436,7 +438,9 @@ outline-minor-mode > + (add-hook 'hack-local-variables-hook > + #'outline-apply-default-state)) Are you sure about modifying the global value of hack-local-variables-hook instead of the buffer-local hook with `nil t' at the end? > Here is a file used to test this feature: > > # -*- mode: outline; -*- > [...] > # Local Variables: > # outline-default-state: 2 > # outline-default-state-subtree-visibility: ((match-regexp . "TOHIDE") subtree-has-long-lines subtree-is-long) > # outline-long-line-threshold: 200 > # outline-line-count-threshold: 100 > # End: When this feature will be used a lot, even variable names will affect usability - with longer names usability deteriorates, and 40 characters of 'outline-default-state-subtree-visibility' takes half of the standard window width. Would it be possible to find a shorter name? Since it defines the rules, how about 'outline-default-rules'? It has the same length as 'outline-default-state', so these names will align nicely: # Local Variables: # outline-default-state: 1 # outline-default-rules: ((match-regexp . "ChangeLog")) # mode: outline-minor # End: Also outline-long-line-threshold and outline-line-count-threshold could share the same prefix, maybe: # outline-default-long-line: 200 # outline-default-line-count: 100