From: Juri Linkov <juri@linkov.net>
To: Ergus <spacibba@aol.com>
Cc: 54074@debbugs.gnu.org
Subject: bug#54074: 29.0.50; Feature request emacs keymap-set and minor-modes
Date: Mon, 21 Feb 2022 10:28:07 +0200 [thread overview]
Message-ID: <86zgmkk5tk.fsf@mail.linkov.net> (raw)
In-Reply-To: <87ley5iclc.fsf@aol.com> (Ergus via's message of "Sun, 20 Feb 2022 20:04:31 +0100")
> 1)
>
> With that then could be trivial to implemented something like
> use-packages :bind, so
>
> (define-minor-mode my-mode
> :global t
> :keymap (my-mode-map
> :map isearch-mode-map my-mode-isearch-map))
>
>
> or similar... I am wondering how nobody have requested this before, when
> it is a very common issue I find in many packages around.
You might be interested in how the composite keymaps are defined here:
```
(define-minor-mode outline-minor-mode
:keymap (easy-mmode-define-keymap
`(([menu-bar] . ,outline-minor-mode-menu-bar-map)
(,outline-minor-mode-prefix . ,outline-mode-prefix-map))
:inherit outline-minor-mode-cycle-map)
```
Maybe such keymap definitions could be simplified.
> 2)
>
> The best approach for this one is to save the original value in an alist
> and assign with a wrapper around setq... and use a loop when disabling
> the mode to restore the original values.... it is not perfect, but works
> in many cases...
> [...]
> Does it makes sense??
Yes, this makes sense. We used the functions copied below
until you proposed to move keybindings to context-menu-mode-map:
```
(defvar context-menu--saved-bindings nil
"Alist of bindings to restore when `context-menu-mode' is disabled.")
(defun context-menu--bind-mouse (click-sym down-sym)
"Enable `context-menu-mode' mouse bindings.
CLICK-SYM and DOWN-SYM are the mouse click and down key symbols to use."
(let ((click (vector click-sym))
(down (vector down-sym)))
(push (cons click-sym (global-key-binding click))
context-menu--saved-bindings)
(global-unset-key click)
(push (cons down-sym (global-key-binding down))
context-menu--saved-bindings)
(global-set-key down context-menu-entry)))
(defun context-menu--restore-bindings ()
"Restore saved `context-menu-mode' bindings."
(pcase-dolist (`(,sym . ,binding) context-menu--saved-bindings)
(let ((key (vector sym)))
(if binding
(global-set-key key binding)
(global-unset-key key)))))
```
prev parent reply other threads:[~2022-02-21 8:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ley5iclc.fsf.ref@aol.com>
2022-02-20 19:04 ` bug#54074: 29.0.50; Feature request emacs keymap-set and minor-modes Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-20 19:39 ` Lars Ingebrigtsen
2022-02-20 21:18 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-20 22:09 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-21 21:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-22 13:22 ` Lars Ingebrigtsen
2022-02-22 14:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-22 14:31 ` Lars Ingebrigtsen
2022-02-22 15:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-23 12:12 ` Lars Ingebrigtsen
2022-02-20 22:34 ` bug#54074: [External] : " Drew Adams
2022-02-21 21:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-21 8:28 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zgmkk5tk.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=54074@debbugs.gnu.org \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).