From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32322: 27.0.50; Connect flymake to next-error-function when enabled Date: Wed, 18 May 2022 21:12:03 +0300 Organization: LINKOV.NET Message-ID: <86zgjed94g.fsf@mail.linkov.net> References: <87zgjfca17.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17713"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 32322@debbugs.gnu.org, Terje Larsen To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 18 20:23:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrOKi-0004Oo-3a for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 May 2022 20:23:40 +0200 Original-Received: from localhost ([::1]:49242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrOKh-00009X-2f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 May 2022 14:23:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrOK6-00007o-LE for bug-gnu-emacs@gnu.org; Wed, 18 May 2022 14:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrOK6-0007C7-50 for bug-gnu-emacs@gnu.org; Wed, 18 May 2022 14:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nrOK6-0000UN-0Q for bug-gnu-emacs@gnu.org; Wed, 18 May 2022 14:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 May 2022 18:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32322 X-GNU-PR-Package: emacs Original-Received: via spool by 32322-submit@debbugs.gnu.org id=B32322.16528981431807 (code B ref 32322); Wed, 18 May 2022 18:23:01 +0000 Original-Received: (at 32322) by debbugs.gnu.org; 18 May 2022 18:22:23 +0000 Original-Received: from localhost ([127.0.0.1]:33635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrOJT-0000T4-5K for submit@debbugs.gnu.org; Wed, 18 May 2022 14:22:23 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:57739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrOJR-0000Sp-DT for 32322@debbugs.gnu.org; Wed, 18 May 2022 14:22:22 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id E52DE100006; Wed, 18 May 2022 18:22:13 +0000 (UTC) In-Reply-To: <87zgjfca17.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 18 May 2022 14:14:44 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232599 Archived-At: >> I know that some other packages utilize the 'next-error-function' to get >> support for 'next-error' and 'previous-error'. I wonder if it would make >> sense to set this up by default when the flymake mode is enabled. I have >> currently enabled it by: >> >> (setq next-error-function 'flymake-goto-next-error) >> >> And it seems to work flawlessly. > > I don't think it would be appropriate for flymake-mode to set that > itself, since that variable is mostly just meant for other > compilation-line major modes to set buffer-locally. But I can see how > it might be convenient for users that mainly just use flymake and not > the regular `M-x compile', so I've now mentioned this in the > flymake-mode doc string in Emacs 29. The problem with enabling next-error-function in buffers where flymake-mode is activated is that there is no evident visual indication that next-error is used to navigate errors in the current buffer. In other modes like compilation the enabled next-error-function is usually indicated by the presence of the compilation window with a list of errors nearby.