From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#59486: completion-auto-wrap disobeyed by vertical navigation Date: Wed, 23 Nov 2022 20:49:27 +0200 Organization: LINKOV.NET Message-ID: <86zgchbj61.fsf@mail.linkov.net> References: <8635aayjm6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40507"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) To: 59486@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 19:51:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxuq7-000AIS-C8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 19:51:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxups-0002P1-P8; Wed, 23 Nov 2022 13:51:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxupq-0002Os-Ir for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 13:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxupq-0005Jv-98 for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 13:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxupq-0004dG-5t for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 13:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 18:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59486 X-GNU-PR-Package: emacs Original-Received: via spool by 59486-submit@debbugs.gnu.org id=B59486.166922943617770 (code B ref 59486); Wed, 23 Nov 2022 18:51:02 +0000 Original-Received: (at 59486) by debbugs.gnu.org; 23 Nov 2022 18:50:36 +0000 Original-Received: from localhost ([127.0.0.1]:56248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxupQ-0004cY-C0 for submit@debbugs.gnu.org; Wed, 23 Nov 2022 13:50:36 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:44459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxupJ-0004c8-Ta for 59486@debbugs.gnu.org; Wed, 23 Nov 2022 13:50:34 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 97CDAFF804 for <59486@debbugs.gnu.org>; Wed, 23 Nov 2022 18:50:21 +0000 (UTC) In-Reply-To: <8635aayjm6.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 22 Nov 2022 19:38:57 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248775 Archived-At: --=-=-= Content-Type: text/plain > In a multi-column layout, the keys and > wrap to the beginning/end of the completions buffer, > but and don't. Here is a patch that supports > completion-auto-wrap for wrapping to the top/bottom: Now pushed. And here are the corresponding commands for navigating the completions buffer from the minibuffer: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=minibuffer-next-completion.patch diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 6bb0fa3ae98..ea1e88c7234 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -4452,7 +4456,7 @@ minibuffer-completion-auto-choose :type 'boolean :version "29.1") -(defun minibuffer-next-completion (&optional n) +(defun minibuffer-next-completion (&optional n vertical) "Move to the next item in its completions window from the minibuffer. When `minibuffer-completion-auto-choose' is non-nil, then also insert the selected completion to the minibuffer." @@ -4461,7 +4465,9 @@ minibuffer-next-completion (with-minibuffer-completions-window (when completions-highlight-face (setq-local cursor-face-highlight-nonselected-window t)) - (next-completion (or n 1)) + (if vertical + (next-line-completion (or n 1)) + (next-completion (or n 1))) (when auto-choose (let ((completion-use-base-affixes t)) (choose-completion nil t t)))))) @@ -4473,6 +4479,20 @@ minibuffer-previous-completion (interactive "p") (minibuffer-next-completion (- (or n 1)))) +(defun minibuffer-next-line-completion (&optional n) + "Move to the next completion line from the minibuffer. +When `minibuffer-completion-auto-choose' is non-nil, then also +insert the selected completion to the minibuffer." + (interactive "p") + (minibuffer-next-completion (or n 1) t)) + +(defun minibuffer-previous-line-completion (&optional n) + "Move to the previous completion line from the minibuffer. +When `minibuffer-completion-auto-choose' is non-nil, then also +insert the selected completion to the minibuffer." + (interactive "p") + (minibuffer-next-completion (- (or n 1)) t)) + (defun minibuffer-choose-completion (&optional no-exit no-quit) "Run `choose-completion' from the minibuffer in its completions window. With prefix argument NO-EXIT, insert the completion at point to the --=-=-=--