From: Juri Linkov <juri@linkov.net>
To: 59486@debbugs.gnu.org
Subject: bug#59486: completion-auto-wrap disobeyed by vertical navigation
Date: Wed, 23 Nov 2022 20:49:27 +0200 [thread overview]
Message-ID: <86zgchbj61.fsf@mail.linkov.net> (raw)
In-Reply-To: <8635aayjm6.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 22 Nov 2022 19:38:57 +0200")
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
> In a multi-column layout, the keys <left> and <right>
> wrap to the beginning/end of the completions buffer,
> but <up> and <down> don't. Here is a patch that supports
> completion-auto-wrap for wrapping to the top/bottom:
Now pushed. And here are the corresponding commands for
navigating the completions buffer from the minibuffer:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: minibuffer-next-completion.patch --]
[-- Type: text/x-diff, Size: 1914 bytes --]
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 6bb0fa3ae98..ea1e88c7234 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -4452,7 +4456,7 @@ minibuffer-completion-auto-choose
:type 'boolean
:version "29.1")
-(defun minibuffer-next-completion (&optional n)
+(defun minibuffer-next-completion (&optional n vertical)
"Move to the next item in its completions window from the minibuffer.
When `minibuffer-completion-auto-choose' is non-nil, then also
insert the selected completion to the minibuffer."
@@ -4461,7 +4465,9 @@ minibuffer-next-completion
(with-minibuffer-completions-window
(when completions-highlight-face
(setq-local cursor-face-highlight-nonselected-window t))
- (next-completion (or n 1))
+ (if vertical
+ (next-line-completion (or n 1))
+ (next-completion (or n 1)))
(when auto-choose
(let ((completion-use-base-affixes t))
(choose-completion nil t t))))))
@@ -4473,6 +4479,20 @@ minibuffer-previous-completion
(interactive "p")
(minibuffer-next-completion (- (or n 1))))
+(defun minibuffer-next-line-completion (&optional n)
+ "Move to the next completion line from the minibuffer.
+When `minibuffer-completion-auto-choose' is non-nil, then also
+insert the selected completion to the minibuffer."
+ (interactive "p")
+ (minibuffer-next-completion (or n 1) t))
+
+(defun minibuffer-previous-line-completion (&optional n)
+ "Move to the previous completion line from the minibuffer.
+When `minibuffer-completion-auto-choose' is non-nil, then also
+insert the selected completion to the minibuffer."
+ (interactive "p")
+ (minibuffer-next-completion (- (or n 1)) t))
+
(defun minibuffer-choose-completion (&optional no-exit no-quit)
"Run `choose-completion' from the minibuffer in its completions window.
With prefix argument NO-EXIT, insert the completion at point to the
next prev parent reply other threads:[~2022-11-23 18:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 17:38 bug#59486: completion-auto-wrap disobeyed by vertical navigation Juri Linkov
2022-11-23 18:49 ` Juri Linkov [this message]
2022-11-24 7:59 ` Juri Linkov
2022-11-24 8:13 ` Eli Zaretskii
2022-11-24 18:30 ` Juri Linkov
2022-11-24 18:43 ` Eli Zaretskii
2022-11-25 7:47 ` Juri Linkov
2022-11-25 8:38 ` Eli Zaretskii
2022-11-28 7:56 ` Juri Linkov
2023-10-31 7:44 ` Juri Linkov
2023-11-01 17:45 ` Juri Linkov
2023-11-02 8:11 ` Eli Zaretskii
2023-11-02 17:14 ` Juri Linkov
2023-11-05 17:53 ` Juri Linkov
2023-11-15 17:45 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zgchbj61.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=59486@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).