unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 65558@debbugs.gnu.org, Pengji Zhang <kunhtkun@gmail.com>
Subject: bug#65558: 30.0.50; project-other-{window,frame,tab}-command a bit too obtrusive
Date: Thu, 19 Oct 2023 21:51:10 +0300	[thread overview]
Message-ID: <86zg0etpi9.fsf@mail.linkov.net> (raw)
In-Reply-To: <40fa876a-e994-7fc9-06d0-26aee0aac6a0@gutov.dev> (Dmitry Gutov's message of "Thu, 19 Oct 2023 21:31:29 +0300")

close 65558 30.0.50
thanks

>>> +;; TODO: maybe rename to project-other-window-prefix
>>>   ;;;###autoload (define-key ctl-x-4-map "p" #'project-other-window-command)
>> Maybe this TODO not needed anymore?
>
> I think you had a point with it, but I'm not sure how strong it is, and
> where is the line between a "x-y-z-command" that does a thing like this and
> a proper "prefix" command. So I'd say it's up to you.
>
> We can remove the TODO, or go ahead with the renaming, or keep the TODO and
> return to it sometime years later when Emacs 30 is the least supported
> version.

With this TODO item I meant something like this:

  ;;;###autoload
  (define-key ctl-x-4-map "p"
    (if (< emacs-major-version 30)
        #'project-other-window-command
      #'project-other-window-prefix))

But now I see it's quite ugly, so I installed the current patch
without TODO.





      reply	other threads:[~2023-10-19 18:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-26 19:25 bug#65558: 30.0.50; project-other-{window,frame,tab}-command a bit too obtrusive Pengji Zhang
2023-08-27 16:13 ` Juri Linkov
2023-08-30  3:58   ` Pengji Zhang
2023-08-30 16:50     ` Juri Linkov
2023-10-19 12:40       ` Dmitry Gutov
2023-10-19 17:49         ` Juri Linkov
2023-10-19 18:31           ` Dmitry Gutov
2023-10-19 18:51             ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zg0etpi9.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=65558@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=kunhtkun@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).