From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#66948: [PATCH] Add Completion Preview mode Date: Mon, 06 Nov 2023 20:05:50 +0200 Organization: LINKOV.NET Message-ID: <86zfzqeoix.fsf@mail.linkov.net> References: <87lebcqcof.fsf@posteo.net> <86a5rrcqd3.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18795"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Dmitry Gutov , Philip Kaludercic , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 66948@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 06 19:18:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r04BZ-0004iW-80 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Nov 2023 19:18:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r04BB-0000H8-Tb; Mon, 06 Nov 2023 13:18:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r04B9-0000C4-Hv for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 13:18:27 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r04B6-0004Fl-Kr for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 13:18:26 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r04Bi-0007Bp-2P for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 13:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Nov 2023 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66948 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66948-submit@debbugs.gnu.org id=B66948.169929469127580 (code B ref 66948); Mon, 06 Nov 2023 18:19:02 +0000 Original-Received: (at 66948) by debbugs.gnu.org; 6 Nov 2023 18:18:11 +0000 Original-Received: from localhost ([127.0.0.1]:40694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r04As-0007Am-Re for submit@debbugs.gnu.org; Mon, 06 Nov 2023 13:18:11 -0500 Original-Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]:55277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r04Aq-0007AE-Bo for 66948@debbugs.gnu.org; Mon, 06 Nov 2023 13:18:09 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id A6B9E1BF206; Mon, 6 Nov 2023 18:17:20 +0000 (UTC) In-Reply-To: (Eshel Yaron's message of "Mon, 06 Nov 2023 16:30:50 +0100") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273892 Archived-At: > If you try it out and have any other suggestions, please let me know. > Here's the updated patch: Thanks, everything works nicely now. Only one thing that I suggest is to add `backward-delete-char-untabify` to `completion-preview-commands` since it's bound to DEL in Lisp buffers. Or there is no way to generalize it for all modes? For example, in c-mode DEL is bound to `c-electric-backspace`, etc.