From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#67145: Modes in vc-deduce-backend Date: Mon, 13 Nov 2023 09:07:32 +0200 Organization: LINKOV.NET Message-ID: <86zfzi6ucr.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34668"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) To: 67145@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 13 08:09:52 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2R4x-0008su-6O for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Nov 2023 08:09:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2R4Y-0004mi-Mh; Mon, 13 Nov 2023 02:09:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2R4T-0004ll-Vx for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 02:09:23 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2R4T-0006KS-08 for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 02:09:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2R58-0006NM-0W for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 02:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Nov 2023 07:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67145 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169985936724460 (code B ref -1); Mon, 13 Nov 2023 07:10:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Nov 2023 07:09:27 +0000 Original-Received: from localhost ([127.0.0.1]:57450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2R4Y-0006MS-Pf for submit@debbugs.gnu.org; Mon, 13 Nov 2023 02:09:27 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:57954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2R4V-0006MC-CY for submit@debbugs.gnu.org; Mon, 13 Nov 2023 02:09:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2R3j-0004ZV-KP for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 02:08:35 -0500 Original-Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2R3f-0006GA-C4 for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 02:08:35 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 8EEBE20003 for ; Mon, 13 Nov 2023 07:08:27 +0000 (UTC) X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::227; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274246 Archived-At: --=-=-= Content-Type: text/plain Here is a patch that avoids hard-coding the modes in vc-deduce-backend. For example, it makes possible to replace shell-mode with comint-mode, etc. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-deduce-backend-modes.patch diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 95f9218dcbf..9c01f032fc0 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1071,14 +1071,16 @@ log-edit-vc-backend (defvar diff-vc-backend) (defvar diff-vc-revisions) +;; Maybe we could even use comint-mode rather than shell-mode? +(defvar vc-deduce-backend-modes '(dired-mode shell-mode eshell-mode compilation-mode)) + (defun vc-deduce-backend () (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) ((derived-mode-p 'log-view-mode) log-view-vc-backend) ((derived-mode-p 'log-edit-mode) log-edit-vc-backend) ((derived-mode-p 'diff-mode) diff-vc-backend) - ;; Maybe we could even use comint-mode rather than shell-mode? - ((derived-mode-p - 'dired-mode 'shell-mode 'eshell-mode 'compilation-mode) + ((or (null vc-deduce-backend-modes) + (apply #'derived-mode-p vc-deduce-backend-modes)) (ignore-errors (vc-responsible-backend default-directory))) (vc-mode (vc-backend buffer-file-name)))) --=-=-=--