From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#67993: Selecting buffer automatically Date: Sat, 23 Dec 2023 19:51:10 +0200 Organization: LINKOV.NET Message-ID: <86zfy0g641.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36774"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: martin rudalics To: 67993@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 23 18:56:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rH6EW-0009PI-EE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Dec 2023 18:56:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rH6EA-0007RJ-Hj; Sat, 23 Dec 2023 12:55:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rH6E9-0007R9-0Y for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 12:55:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rH6E8-00064c-Oj for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 12:55:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rH6ED-00025F-Rf; Sat, 23 Dec 2023 12:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: rudalics@gmx.at, bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Dec 2023 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67993 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: martin rudalics Original-Received: via spool by submit@debbugs.gnu.org id=B.17033541057942 (code B ref -1); Sat, 23 Dec 2023 17:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Dec 2023 17:55:05 +0000 Original-Received: from localhost ([127.0.0.1]:51179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH6DJ-000241-Gi for submit@debbugs.gnu.org; Sat, 23 Dec 2023 12:55:05 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:60862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH6DH-00023Q-7A for submit@debbugs.gnu.org; Sat, 23 Dec 2023 12:55:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rH6D6-0007Mn-J3 for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 12:54:52 -0500 Original-Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rH6D5-0004or-0k for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 12:54:52 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 3CF3C240002 for ; Sat, 23 Dec 2023 17:54:46 +0000 (UTC) X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::221; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276759 Archived-At: --=-=-= Content-Type: text/plain [From emacs-devel] >>> I believe this should be customizable with something like >>> >>> (setopt display-buffer-alist >>> '(("\\*Compile-Log\\*" nil (select-window . t)))) >> >> Thank you for the advice, but I tried this and it didn't work. >> *Compile-log* buffer isn't selected. > > This feature was discussed in bug#33258 and bug#46034, > but not yet implemented. It should be easy to implement > exactly the same way as 'windmove-display-in-direction' > selects the old or new window in 'post-command-hook'. > Ok, I will post a patch to bug-gnu-emacs. Here is the patch that allows using (select-window . t) in display-buffer-alist to select the displayed window, and (select-window . nil) to deselect windows selected by such functions as pop-to-buffer: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=select-window.patch diff --git a/lisp/window.el b/lisp/window.el index 40070a4d929..fad95601a55 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -7851,6 +7856,16 @@ display-buffer (while (and functions (not window)) (setq window (funcall (car functions) buffer alist) functions (cdr functions))) + (when-let ((select-window (assq 'select-window alist))) + (letrec ((postfun + (lambda () + (if (cdr select-window) + (when (window-live-p window) + (select-window window)) + (when (window-live-p (old-selected-window)) + (select-window (old-selected-window)))) + (remove-hook 'post-command-hook postfun)))) + (add-hook 'post-command-hook postfun))) (and (windowp window) window)))) (defun display-buffer-other-frame (buffer) --=-=-=--