From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70221: [PATCH] New function `funcall-later` Date: Sat, 06 Apr 2024 09:36:00 +0300 Message-ID: <86zfu73smn.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9813"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70221@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 06 08:37:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rszfs-0002Lr-KD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Apr 2024 08:37:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rszfd-0006gE-NQ; Sat, 06 Apr 2024 02:36:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rszfc-0006g5-Ed for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 02:36:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rszfc-00080N-6Q for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 02:36:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rszfi-0006zL-5s for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 02:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2024 06:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70221 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70221-submit@debbugs.gnu.org id=B70221.171238538026575 (code B ref 70221); Sat, 06 Apr 2024 06:37:02 +0000 Original-Received: (at 70221) by debbugs.gnu.org; 6 Apr 2024 06:36:20 +0000 Original-Received: from localhost ([127.0.0.1]:38010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rszf0-0006uX-Ky for submit@debbugs.gnu.org; Sat, 06 Apr 2024 02:36:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rszex-0006uH-7r for 70221@debbugs.gnu.org; Sat, 06 Apr 2024 02:36:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rszel-0007j9-2G; Sat, 06 Apr 2024 02:36:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YRORXZvNSBeXHqvrs76c6P1p2EApposiQDo0NmZQYP0=; b=jxST1smnfTxt C271NwyHy3WWJLXK2MYxh3jqdUUJb0uxBko7n6QUtQPhm8WkXQ5iU1xDWSocC2VpP86MWyND6zbTw 01ixn2gPbWjU0nC93VVyG8+6m+EiEwWg4xkTeHYsLDSplH4xHJonerFsNU8Ya7ULl9E2i29qYg2Wk XxDi+Q5F4UJx3byk+U9/FNZZu1t1J39BGq9zdInT4A8Z4m+uli+VbCmX8IdngaU8CeJ0XbVIBz5/m NDvCFBUcKFStHw1/CtxJGQHMt9NFp8OWqm9QW1eZz628FNSni/OM0Ltiz0xaYgrOrXV7rHDyXUkN2 jqjP2HA538Nj1qYKy0vtIQ==; In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282740 Archived-At: > Date: Fri, 05 Apr 2024 15:56:40 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > +DEFUN ("internal--run-pending-funcalls", Frun_pending_funcalls, Srun_pending_funcalls, 0, 0, 0, > + doc: /* Run the still pending `funcall-later'. */) > + (void) > +{ > + while (CONSP (pending_funcalls) || CONSP (pending_funcalls_r)) > + if (CONSP (pending_funcalls)) > + { > + Lisp_Object funcall = XCAR (pending_funcalls); > + pending_funcalls = XCDR (pending_funcalls); > + CALLN (Fapply, funcall); > + } > + else You are using CALLN here, whereas the previous implementation used safe_calln. Is that intended? Calling Lisp in unsafe ways in that place might not be a good idea. You didn't even inhibit QUIT. As another difference between run-with-time and this mechanism, the former took care of preserving deactivate-mark around the call, wheres funcall-later doesn't -- this is at least one difference that we should document (assuming we want it).