From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints" Date: Thu, 02 May 2024 21:14:29 +0300 Message-ID: <86zft8jd2y.fsf@gnu.org> References: <45C35B69-6DA8-4212-BD87-50B2A3959A86@gmail.com> <86h6fo3e7e.fsf@mail.linkov.net> <86cyqaezhc.fsf@mail.linkov.net> <86ttjle92p.fsf@mail.linkov.net> <86zft8676h.fsf@mail.linkov.net> <86r0ekn0o0.fsf@gnu.org> <86sez06w59.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6758"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70576@debbugs.gnu.org, jdtsmith@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 02 20:16:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2ayU-0001XJ-I1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 May 2024 20:16:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2ayM-0002QZ-MS; Thu, 02 May 2024 14:15:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2ayB-0002Kb-IH for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 14:15:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2ay4-0004hl-Ll for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 14:15:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2ayQ-0005fi-FX for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2024 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70576 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70576-submit@debbugs.gnu.org id=B70576.171467373218033 (code B ref 70576); Thu, 02 May 2024 18:16:02 +0000 Original-Received: (at 70576) by debbugs.gnu.org; 2 May 2024 18:15:32 +0000 Original-Received: from localhost ([127.0.0.1]:45162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2axw-0004fW-7v for submit@debbugs.gnu.org; Thu, 02 May 2024 14:15:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2axs-0004JO-RY for 70576@debbugs.gnu.org; Thu, 02 May 2024 14:15:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2axP-0004Ol-GL; Thu, 02 May 2024 14:15:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GMbArUQ+i0BpmQWcGWA6y1vKcF9ptjwN47Iuk0yklME=; b=lxCxt/CuUfsF amjo37A3hKjF/ITrgt4VRFt0dyU+iRfzWZKn7BWOJ65FW/91e+hF86wqH8v71x9nCJckKU5gTDKyE DEvyiGjRK2YC1wEm4AJUIQ3jy0ElezW/r5odrX6IWrzKyGXy/PPzVDYfsTQwlwWCPv/pbIhu82ALf hHmzEsFvN2h5c1Dxkfx8d4gQEp/5cewJSx2L6cs3fqIFUfByWp/+N4jEVWgQtxaV4G9f9SGAF3A9g PkfqwyspYcjMCyECJk/mLzXMKcBo9NIOyZg+mc9qYbWtfzrGNBxDKZ3DDLckWHdE3s3ep5EFv7t+x 00NPjPE5CfDoDod/v0VlYw==; In-Reply-To: <86sez06w59.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 02 May 2024 19:16:06 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284340 Archived-At: > From: Juri Linkov > Cc: jdtsmith@gmail.com, 70576@debbugs.gnu.org > Date: Thu, 02 May 2024 19:16:06 +0300 > > >> >>> (defvar-keymap expreg-repeat-map > >> >>> :doc "Repeat map for `expreg' actions." > >> >>> :repeat '(:hints ((expreg-expand . "expand") (expreg-contract . "contract"))) > >> >>> "\\" 'expreg-expand > >> >>> "|" 'expreg-contract) > >> >> > >> >> If a hint is missing for a command, it should just have its key mentioned. > >> >> It looks like your idea would require changes to defvar-keymap. Do you > >> >> want to propose a patch? We'd need some way to pass the hints in; perhaps > >> >> the macro could set a property on the command symbol as you initially > >> >> proposed. > >> > > >> > Alright, let's add this to defvar-keymap. Please try the following patch. > >> > >> Thanks for the feature request. This is pushed now. > > > > Thanks, but please also update the ELisp manual and add an entry to > > NEWS about this change. > > A NEWS entry was already added with "---" since I didn't expect that > such a small feature that is not used anywhere needs to grow > the size of the manual. I don't see how we can avoid updating the ELisp manual, when the other values of :repeat are already documented there, see the node "Creating Keymaps". So please add the description of the new value to those already documented there.