unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: dmitry@gutov.dev, 71179@debbugs.gnu.org
Subject: bug#71179: [PATCH] In rgrep, check matching files before excluding files
Date: Sat, 25 May 2024 17:13:17 +0300	[thread overview]
Message-ID: <86zfsex9mq.fsf@gnu.org> (raw)
In-Reply-To: <CAO=BR8OcPjOUrP-aBnNaYn-H5C1sehmvmb5h9V+UHFByO7+4ew@mail.gmail.com> (message from Spencer Baugh on Sat, 25 May 2024 10:02:02 -0400)

> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Sat, 25 May 2024 10:02:02 -0400
> Cc: Dmitry Gutov <dmitry@gutov.dev>, 71179@debbugs.gnu.org
> 
> On Sat, May 25, 2024, 9:57 AM Eli Zaretskii <eliz@gnu.org> wrote:
> 
>  For example, you never
>  considered the cases where the files which match the pattern to search
>  also match the ignored-extensions, and many other possibilities.  
> 
> In that case the file will not be searched, same as before this change.  No behavior change.

We are talking about performance here.

> What other possibilities?

Who knows?  Why risk any changes at all?

Anyway, I suggested an approach that should leave everyone happy.  Why
are we still arguing?





  reply	other threads:[~2024-05-25 14:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 20:14 bug#71179: [PATCH] In rgrep, check matching files before excluding files Spencer Baugh
2024-05-24 20:45 ` Dmitry Gutov
2024-05-24 20:54   ` Spencer Baugh
2024-05-25 12:31     ` Dmitry Gutov
2024-05-26  6:50       ` Juri Linkov
2024-05-26 12:48         ` Spencer Baugh
2024-05-26 12:56         ` Dmitry Gutov
2024-05-25  6:36 ` Eli Zaretskii
2024-05-25 12:26   ` Dmitry Gutov
2024-05-25 12:51     ` Eli Zaretskii
2024-05-25 13:03       ` Dmitry Gutov
2024-05-25 13:45         ` Eli Zaretskii
2024-05-25 13:58           ` Dmitry Gutov
2024-05-25 13:36       ` Spencer Baugh
2024-05-25 13:56         ` Eli Zaretskii
2024-05-25 14:02           ` Spencer Baugh
2024-05-25 14:13             ` Eli Zaretskii [this message]
2024-05-25 14:47               ` Dmitry Gutov
2024-05-25 15:07                 ` Eli Zaretskii
2024-05-26 13:42                   ` Spencer Baugh
2024-06-01 14:15                     ` Eli Zaretskii
2024-06-02 10:46                       ` Stefan Kangas
2024-05-25 14:51               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zfsex9mq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71179@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).