From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 71345@debbugs.gnu.org, jdtsmith@gmail.com, dmitry@gutov.dev
Subject: bug#71345: Feature: unleash font-lock's secret weapon; handle Qfontified = non-nil
Date: Wed, 05 Jun 2024 20:52:42 +0300 [thread overview]
Message-ID: <86zfrzi8et.fsf@gnu.org> (raw)
In-Reply-To: <jwvfrtrjpny.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Wed, 05 Jun 2024 12:59:08 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: jdtsmith@gmail.com, 71345@debbugs.gnu.org, dmitry@gutov.dev
> Date: Wed, 05 Jun 2024 12:59:08 -0400
>
> >> But the highlighting is done "once and for all" (at least until the next
> >> command), so if you want it to be different in different windows (to
> >> reflect the different values of `point` in those windows) you'll need
> >> overlays with the `window` property because the highlighting will not be
> >> re-done in the middle of redisplay when we go from one window to another.
> >
> > In that case, we are in trouble anyway, because the "once and for all"
> > highlighting could be (by sheer luck) be done by display code that
> > doesn't run as part of redisplay, but as part of something else, like
> > vertical-motion.
>
> I can't see why that would be a problem.
>
> The highlighting code run from `jit-lock` will usually not be able to
> use `point` (or `window-point`) directly. Instead, that highlighter
> will need to keep track of the windows' points elsewhere "manually" via
> hooks like `post-command-hook` or `pre-redisplay-functions` and then
> rely on that info when performing the highlighting.
You say you don't see a problem, but then describe a solution for a
problem you don't see? ;-)
Yes, if the code run from jit-lock will use some private variable
instead of point, it can get away, but such a code will need to be
written in an extremely disciplined manner, like nothing else in Emacs
(except, perhaps, the inner parts of redisplay code in C), because
what is more natural than call functions and APIs under the assumption
that point is where it's expected to be?
next prev parent reply other threads:[~2024-06-05 17:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 16:35 bug#71345: Feature: unleash font-lock's secret weapon; handle Qfontified = non-nil JD Smith
2024-06-03 16:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 21:14 ` JD Smith
2024-06-04 1:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 12:08 ` JD Smith
2024-06-04 14:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 15:38 ` JD Smith
2024-06-04 21:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 22:41 ` JD Smith
2024-06-05 11:29 ` Eli Zaretskii
2024-06-05 14:02 ` JD Smith
2024-06-05 14:53 ` Eli Zaretskii
2024-06-05 15:52 ` JD Smith
2024-06-05 17:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-05 17:24 ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-05 11:24 ` Eli Zaretskii
2024-06-05 14:05 ` JD Smith
2024-06-05 16:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-05 16:38 ` Eli Zaretskii
2024-06-05 16:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-05 17:52 ` Eli Zaretskii [this message]
2024-06-05 18:13 ` JD Smith
2024-06-07 3:27 ` JD Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zfrzi8et.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71345@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=jdtsmith@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).