bug#72826: 30.0.90; icomplete-in-buffer becomes unusably slow in large Eshell

[Eli Zaretskii <eliz@gnu.org>]

> From: Sean Whitton <spwhitton@spwhitton.name>
> Cc: joaotavora@gmail.com,  72826@debbugs.gnu.org,  juri@linkov.net
> Date: Sat, 05 Oct 2024 08:21:56 +0800
> 
> On Fri 04 Oct 2024 at 05:33pm +03, Eli Zaretskii wrote:
> 
> > Thanks.  But the difference between the two cases is larger than the
> > difference between the first and the second line of the prompt.  How
> > do you explain that?  Also, why doesn't the first image show more
> > candidates, so as to use all of the second screen line in the
> > mini-window? is that expected?
> 
> It's expected, indeed.  The explanation for all the cases you ask about
> here is that the parts of the algorithm subsequent to the computation of
> prospects-max do not try especially hard to fill up prospects-max.
> 
> My patch to address this bug only attempts to correct the computation of
> prospects-max, not to make any change to how that value is subsequently
> used.  If you think the latter should be changed, I think that should be
> a separate bug report.  (Speaking as a longterm Icomplete user, I don't
> especially think it needs to change.)

Thanks, I'm convinced.  Please install your changes.