From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73782: [PATCH] Add `delete-selection-local-mode'. Date: Sun, 13 Oct 2024 08:38:38 +0300 Message-ID: <86zfn8tvdt.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13456"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73782@debbugs.gnu.org To: Okamsn , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 13 07:40:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szrKk-0003KG-B7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Oct 2024 07:40:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szrKc-0002c8-4A; Sun, 13 Oct 2024 01:39:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szrKV-0002br-QG for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 01:39:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szrKV-0004IC-E6 for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 01:39:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=dI7YLVy+k/RVD7SfU0hFw9mXv4BgXLJxaJvbziWkyBo=; b=d9rJM5bGA8kxmvAYe2ONcwwZHfm8k2k4eUedyLcqqy+Mt93zrgWVDjSCGPHfgdmQGGd17+2hi0C5KIIN97oPPkOy584GR4us5hIbYgJrnR4or34cdcH2EYSmh5k6j6NDvho+u6f2DvosNSGBRsya1HExjfgtWX024kKPL1dEK7OU5kZ4tYn0lRNySCpnX8aE7+xrGgVJiSje0Ny+siQk0dRPuR3xUbD9hWy/01IG/lTXvlpO7jwk8dyJcmqb+ZjlXoJ3i7k2d4AF2tXY+iRTC1h4zSpWf+tSwG6M3e30RFTWoGlW79IPS2oME60I4RA3uEhPcgHMJ50x8p0hHsj5xQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szrKk-0001cI-Dx for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 01:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2024 05:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73782 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73782-submit@debbugs.gnu.org id=B73782.17287979456128 (code B ref 73782); Sun, 13 Oct 2024 05:40:02 +0000 Original-Received: (at 73782) by debbugs.gnu.org; 13 Oct 2024 05:39:05 +0000 Original-Received: from localhost ([127.0.0.1]:49929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szrJp-0001am-5S for submit@debbugs.gnu.org; Sun, 13 Oct 2024 01:39:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szrJn-0001aH-Or for 73782@debbugs.gnu.org; Sun, 13 Oct 2024 01:39:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szrJR-0004ET-AX; Sun, 13 Oct 2024 01:38:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dI7YLVy+k/RVD7SfU0hFw9mXv4BgXLJxaJvbziWkyBo=; b=Ld8Ev9+jKhSu rJBLKLEkoVFuvLGL4EXEtUURiQxpBx0vNlXMKNe23ULltDQ7Rmo7qCsTRBG1ZyrAfud+gDYsdcVo6 z/+sZhXtFKisHT3+mAZDHK6/EYwkhSLWhr4CEV4SokYHkoZ4h/j021MHA21YyRTDgdSCYz1+LOVXC KtD/aNOVNS/Xe8KkyHT7qjL3tqSarVWf/Bd/gZSscXGueZcSrEnxVgB81Q9CX39TxtVif2eKRjUY/ bs4gFQDYlx71OCpWIQkWm9q/7OdiVk5efMe+ZiiLrUJdbJDWThjzrATc2cdojywWE7jsFnX+gOJlG HnmI6P91uGei+yi4KcLarw==; In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293496 Archived-At: > Date: Sun, 13 Oct 2024 01:25:28 +0000 > From: Okamsn via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This patch adds a local version of `delete-selection-mode`. I use a > modal editing package for which I would like to have > `delete-selection-mode` enabled depending on the modal state that is > active in the buffer. This doesn't currently work because > `delete-selection-mode` applies to all buffers. Thanks. This feature needs a NEWS entry, and maybe also a suitable change to the user manual. > For compatibility, I made the local mode set the value of the variable > `delete-selection-mode` buffer locally. I see that some features, such > as the built-in `table.el`, check that variable to adjust their > behavior. Do you think that is a good way to maintain compatibility? SGTM, but I'd like to hear from Stefan (CC'ed) as well.