From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73863: 30.0.91; Unexpected cursor movement with flymake-show-diagnostics-at-end-of-line Date: Sun, 20 Oct 2024 14:22:24 +0300 Message-ID: <86zfmzhvdb.fsf@gnu.org> References: <86r08dmm0h.fsf@gnu.org> <86plnxmfdt.fsf@gnu.org> <86y12kjks0.fsf@gnu.org> <86a5ezjkx8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39785"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73863@debbugs.gnu.org, romain.ouabdelkader@gmail.com To: sbaugh@janestreet.com, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 20 13:23:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2U1X-000ACM-SM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Oct 2024 13:23:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2U1D-0008MO-SZ; Sun, 20 Oct 2024 07:22:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2U18-0008Lo-Ei for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 07:22:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2U17-0001al-8B for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 07:22:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=yfm8yTJDje0Fu2fpWFmF3UpO85VlvKdwPRc3Jn1P0L4=; b=rxFTVuckBt+Jno+WHk4/jO4w4ji9cBdJ79E0lkqz2RnPhkNyYZoH+GxfREwTiTu6JF02ckrnCfh6AtE/vKy6nrioPeEPLI/P5u2V7OmGtWD/xtzUhDsVwF6bz9hf3f7BjFvUWlRp8kEpn3fMkwWz7SAhEgO1zPWhlSle+pqzV0nWW8dGEl/GK2v+1A4nS9m5GkUKE7D0Mv5ttJo6+f7Hwdj4WVg7iC7QbBJHbIn/pMNRXPnponE6YcPTpj4LX+WG56VwQOAxMYMjU/MwAhahDjFOdPo+Qa75L8QDd8oIcTrTUHoMDxrHLm5nEAF02oaTI4CpSjnvJp9Rk58rcM39Ew==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2U1W-0001nR-4R for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 07:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2024 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73863 X-GNU-PR-Package: emacs Original-Received: via spool by 73863-submit@debbugs.gnu.org id=B73863.17294233816898 (code B ref 73863); Sun, 20 Oct 2024 11:23:02 +0000 Original-Received: (at 73863) by debbugs.gnu.org; 20 Oct 2024 11:23:01 +0000 Original-Received: from localhost ([127.0.0.1]:46041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2U1U-0001nC-Kk for submit@debbugs.gnu.org; Sun, 20 Oct 2024 07:23:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2U1T-0001mo-G8 for 73863@debbugs.gnu.org; Sun, 20 Oct 2024 07:22:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2U0y-0001a3-Pi; Sun, 20 Oct 2024 07:22:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=yfm8yTJDje0Fu2fpWFmF3UpO85VlvKdwPRc3Jn1P0L4=; b=QH6R7nrV4LGiJED4pI1D QFuvguwI0vyjranHLJYXoqtDFxGeL3U2c8uAi/kgMk7onipNXv8VIzlNaVypaYAzFzg+CA8yUjmiJ C1fww3rm3oCR2deb/yD1pRPuBgRv0i5O+IoFWq7+kwtqin8ERyj+HdkRnWQH8lGFsPCYlXvAIwXUx 4vDoPh8E/W4ewDeBRR3+NGZ7EptdGG7vZgJjP2a2HXmcpjHQv1WAJVC8cf7239aseDnbnuVIUJa73 K5vcDCvjbLCi9+bXRVpzfZqPsWmsM0a4VVSWPMEi8GVDjBtaGK/7ItGY4Jlv9oIhvoWVdW0RfC34Q nMMJEGdHuGpjig==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sun, 20 Oct 2024 10:28:50 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293947 Archived-At: > From: João Távora > Date: Sun, 20 Oct 2024 10:28:50 +0100 > Cc: Romain Ouabdelkader , 73863@debbugs.gnu.org > > Flymake queries should be directed to Spencer Baugh Sorry, I keep forgetting that. > But if this fixes the user's problem and doesn't hurt anyone who does > have wide enough windows and on top of that sufficient testing is done, > I don't object to this solution. I don't know what that problem is. Does > the user want their cursor to show at the end of the intangible overlay? > If so, that's odd: I designed this feature to be as little intrusive as possible > i.e. so that turning it on has no other effect than some text appearing > at the end of line -- and only at the end of line. If there is little space, I > would say the right thing to do is to truncate, not wrap to the next line When the diagnostic overlay wraps to the next screen line, it is strange to see the cursor at the beginning of the diagnostic after C-n, since users generally expect C-n to move to the next screen line. But if we decide that the current behavior is more reasonable, and this is just a matter of users getting used to it, I don't mind leaving the current behavior alone. > To try and answer your question, I don't think it is used by other Flymake > parts (the function name hints at it: flymake--eol- means "end of line"). > However, I advise to give it testing (with multiple diagnostics on one > line, for example). I remember trying many variations on these things > and each had its drawbacks. But possibly (probably?) I didn't test > this one. Anyway, do test this out with other flymake eol users and > consider the impact to users with wide enough windows: if there's no > impact I don't see why this wouldn't be acceptable. But that is for > Spencer or you to decide. Thanks. Spencer, what say you?