unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: sbaugh@janestreet.com, "João Távora" <joaotavora@gmail.com>
Cc: 73863@debbugs.gnu.org, romain.ouabdelkader@gmail.com
Subject: bug#73863: 30.0.91; Unexpected cursor movement with flymake-show-diagnostics-at-end-of-line
Date: Sun, 20 Oct 2024 14:22:24 +0300	[thread overview]
Message-ID: <86zfmzhvdb.fsf@gnu.org> (raw)
In-Reply-To: <CALDnm50sqfp_3P5svMSo9v9s7MOFP009JT_szxk4ta83xVcLqg@mail.gmail.com> (message from João Távora on Sun, 20 Oct 2024 10:28:50 +0100)

> From: João Távora <joaotavora@gmail.com>
> Date: Sun, 20 Oct 2024 10:28:50 +0100
> Cc: Romain Ouabdelkader <romain.ouabdelkader@gmail.com>, 73863@debbugs.gnu.org
> 
> Flymake queries should be directed to Spencer Baugh

Sorry, I keep forgetting that.

> But if this fixes the user's problem and doesn't hurt anyone who does
> have wide enough windows and on top of that sufficient testing is done,
> I don't object to this solution.  I don't know what that problem is.  Does
> the user want their cursor to show at the end of the intangible overlay?
> If so, that's odd: I designed this feature to be as little intrusive as possible
> i.e. so that turning it on has no other effect than some text appearing
> at the end of line -- and only at the end of line.  If there is little space, I
> would say the right thing to do is to truncate, not wrap to the next line

When the diagnostic overlay wraps to the next screen line, it is
strange to see the cursor at the beginning of the diagnostic after
C-n, since users generally expect C-n to move to the next screen line.

But if we decide that the current behavior is more reasonable, and
this is just a matter of users getting used to it, I don't mind
leaving the current behavior alone.

> To try and answer your question,  I don't think it is used by other Flymake
> parts (the function name hints at it: flymake--eol- means "end of line").
> However, I advise to give it testing (with multiple diagnostics on one
> line, for example). I remember trying many variations on these things
> and each had its drawbacks.  But possibly (probably?) I didn't test
> this one.  Anyway, do test this out with other flymake eol users and
> consider the impact to users with wide enough windows: if there's no
> impact I don't see why this wouldn't be acceptable. But that is for
> Spencer or you to decide.

Thanks.

Spencer, what say you?





  reply	other threads:[~2024-10-20 11:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 15:09 bug#73863: 30.0.91; Unexpected cursor movement with flymake-show-diagnostics-at-end-of-line Romain Ouabdelkader
2024-10-18 16:08 ` Eli Zaretskii
2024-10-18 16:24   ` Romain Ouabdelkader
2024-10-18 18:31     ` Eli Zaretskii
2024-10-18 19:10       ` Romain Ouabdelkader
2024-10-19 13:15         ` Eli Zaretskii
2024-10-19 13:41           ` Romain Ouabdelkader
2024-10-20  7:25             ` Eli Zaretskii
2024-10-20  9:28               ` João Távora
2024-10-20 11:22                 ` Eli Zaretskii [this message]
2024-10-20 11:38                   ` João Távora
2024-10-20 11:49                     ` Eli Zaretskii
2024-10-20 14:42                       ` João Távora
2024-10-20 15:01                         ` Romain Ouabdelkader
2024-10-20 15:49                           ` Eli Zaretskii
2024-10-20 16:23                             ` Eli Zaretskii
2024-10-20 15:31                         ` Eli Zaretskii
2024-10-20 15:39                           ` João Távora
2024-10-20 16:30                             ` Eli Zaretskii
2024-10-20 16:58                               ` João Távora
2024-10-20 17:50                                 ` Eli Zaretskii
2024-10-20 18:05                                   ` João Távora
2024-10-20 18:28                                     ` Eli Zaretskii
2024-10-20 19:18                                       ` João Távora
2024-10-18 19:16       ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 19:25         ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zfmzhvdb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=73863@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=romain.ouabdelkader@gmail.com \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).