From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74338: 29.1; JSON RPC timeout too short in some cases Date: Sat, 23 Nov 2024 22:16:38 +0200 Message-ID: <86zflpk8nt.fsf@gnu.org> References: <80qbjyjjod3.fsf@eurocontrol.int> <86bjyil0pg.fsf@gnu.org> <86plmmkrna.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24479"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jurgen.de-backer.ext@eurocontrol.int, daniel@dpettersson.net, 74338-done@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 23 21:17:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEwZU-0006Em-NJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Nov 2024 21:17:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEwZ2-0000EH-2p; Sat, 23 Nov 2024 15:17:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEwYy-0000Dr-Q5 for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 15:17:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEwYx-0003wY-6V for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 15:17:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=2KV6PlbfONo3MVSmwjyILMcjvlt66igphZzwnc50g2U=; b=bS3/9NxFhlQpzxDGstbXK/C/Qo8bV6IXHmzAmocUGvUNQtmguN6nEzAadD2pSVvyhFjidexSJBYlbRREkAIcPTxioTLtK6sVwFCjJFWXv7rSAMJLJ8suM6V30wi9R7wsT14s7fmDiHDp/FBJ08FayOPBRdSHSjMndR3oEUdGkFUV3pQVe2ut3gwpPF/+g9IEE+FmJKlpt2cyg1TVEUM+W72glnwxKN5AdSKJZiTZnFPor9NvzEeZvgqADuWBzgFlhxo9FI2nPpU+6N1yBhrg3TTwj5aSB+GGL76Aq8GbG4nOZW48jwrYJMlRTOMZqhQMXNegYUkL5m/BTrxvrSFCEg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEwYw-00045j-QP for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 15:17:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2024 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74338 X-GNU-PR-Package: emacs Mail-Followup-To: 74338@debbugs.gnu.org, eliz@gnu.org, jurgen.de-backer.ext@eurocontrol.int Original-Received: via spool by 74338-done@debbugs.gnu.org id=D74338.173239301015693 (code D ref 74338); Sat, 23 Nov 2024 20:17:02 +0000 Original-Received: (at 74338-done) by debbugs.gnu.org; 23 Nov 2024 20:16:50 +0000 Original-Received: from localhost ([127.0.0.1]:59582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEwYk-000452-AG for submit@debbugs.gnu.org; Sat, 23 Nov 2024 15:16:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEwYh-00044k-Bc for 74338-done@debbugs.gnu.org; Sat, 23 Nov 2024 15:16:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEwYb-0003pE-B4; Sat, 23 Nov 2024 15:16:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2KV6PlbfONo3MVSmwjyILMcjvlt66igphZzwnc50g2U=; b=hrKqXb+Sc/pxnuB5pCOG EIQFTqKDwBx3i6RUofpfFhoUnvlunX02Fjq9PWFn3KdGQPjqNejx79j90Dfuhx/1PBIaIzQ/K1wEC n4S4oO9t6Pb84QqsnAHGn0XKdLLhMxpLFwHHCytUKhUkNTxBBmhjnVDrFVohkl9dSI75ytg7rRJNk KrVr7NC8owc6iL7xz1yYVnVY3oaj9iARFF2jaTHrJQryHCNlJGLfAfrrnal809ZSJR67kwrbYh0Jo c31D8767F4tAz9Mq4/l+JQVt9IDYrXnixg4YG54NCuj2OVo2q7hGA4yibTTS5JSwW0RugAnjbB6Xk uWk1Hjp007BvPw==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 23 Nov 2024 19:53:23 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295869 Archived-At: > From: João Távora > Date: Sat, 23 Nov 2024 19:53:23 +0000 > Cc: Daniel Pettersson , jurgen.de-backer.ext@eurocontrol.int, > 74338@debbugs.gnu.org > > On Sat, Nov 23, 2024 at 1:26 PM Eli Zaretskii wrote: > > > > > From: Daniel Pettersson > > > Cc: Jurgen De Backer , > > > 74338@debbugs.gnu.org > > > Date: Sat, 23 Nov 2024 01:23:16 +0100 > > > > > > Eli Zaretskii writes: > > > > > > >> Date: Wed, 13 Nov 2024 12:43:20 +0000 > > > >> From: Jurgen De Backer via "Bug reports for GNU Emacs, > > > >> the Swiss army knife of text editors" > > > >> > > > >> > > > >> Hi, > > > >> When using emacs together with eglot/ada_language_server, > > > >> some requests may take longer than the 10 seconds specified in > > > >> jsonrpc.el (defconst jsonrpc-default-request-timeout 0). > > > >> It would be better to be able to change this default value. > > > > > > > > Daniel, any comments or suggestions? Maybe we should make that > > > > variable a defcustom? > > > > > > No real harm in converting it, it might be better of it was configured > > > on eglot as eglot-default-request-timeout but that would require some > > > work in eglot I believe. The argument against it is that it could > > > have unintended consequences for other users of jsonrpc, but I think > > > it's something we can live with. > > > > João, any reasons not to make this variable a defcustom? > > Not at all, if you're talking about jsonrpc-default-request-timeout, > but that's up to Daniel jsonrpc.el maintainer. Thanks. Daniel already agreed, so I've now done that, and with that I'm closing this bug.