From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74637: [PATCH] Make view-read-only behave like view-file Date: Tue, 03 Dec 2024 16:01:10 +0200 Message-ID: <86zflc27dl.fsf@gnu.org> References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <87mshdjd2k.fsf@> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28432"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74637@debbugs.gnu.org To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar , Stefan Kangas , Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 03 15:04:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tITVr-0007FC-Kh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Dec 2024 15:04:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tITVW-0007EU-50; Tue, 03 Dec 2024 09:04:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tITVT-0007ED-Hb for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2024 09:04:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tITVS-0004Q0-VN for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2024 09:04:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=cgsji8Z48hrluzwOAQX2lAOMrkFRkvbJ1anDmB65pBk=; b=cuWk3e8kUJcrFeDS8UCmmmlVsxYNsq7LBpofCN8wwBQ9ka4EvQtkKbaaohlRoipwnaIY/2nd3fIU6SnKr+1mQbp2UhLHHDYs+vna/VKBbzP3UK3XjszlHltdXk2tjAiOz3XzGOXwnH/pxP8TZwB/kb8+PHD3ijBQ6l8sxt3Dy+BPgR3ARTT425kTfF6FBn4j5qMbelYgslow5BofO/chjBuDd7eX95Uok9/636jAoFT5nWKnWCr1JhHrmQ5TZ32xmus0u5B8+ZT1rxkYKyshTcA1ZPdG79Hw3AgyksPIXjbEnM0JJAZmbqYmZKEzOkeOY1rHQfPGPbEkjBebfMYNow==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tITVS-00088z-7e for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2024 09:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Dec 2024 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74637-submit@debbugs.gnu.org id=B74637.173323463831294 (code B ref 74637); Tue, 03 Dec 2024 14:04:02 +0000 Original-Received: (at 74637) by debbugs.gnu.org; 3 Dec 2024 14:03:58 +0000 Original-Received: from localhost ([127.0.0.1]:58761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tITVN-00088g-W3 for submit@debbugs.gnu.org; Tue, 03 Dec 2024 09:03:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tITVI-00088J-LW for 74637@debbugs.gnu.org; Tue, 03 Dec 2024 09:03:55 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tITT4-0004H1-Pg; Tue, 03 Dec 2024 09:01:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cgsji8Z48hrluzwOAQX2lAOMrkFRkvbJ1anDmB65pBk=; b=LhDVAC5rL3UQ9ewejOl8 hUyoKJ3RYNh2CEgcHk2KeLoDGM8i6T2fDs7gHgN+pujsucx4B6aJNeF9/HwloNE0msB2Ix7vuscsB BqsHITke1v19OjR96xIDtoMJFtrp7r7HYqELnoZuSpOXSxKrC9rt4zO3NbVVHO0Bvavf4YZUuSgsK NjNOvDdcXVL/TdYdkmQFW08sJEVAz5O20mJEyetUlbDIGoD3RZymOmOeBlUVH9+fxNP2wiRQbxWCK ODmGZHsXQBYrax12VkrsdS3n0zbKBFX36T7NJllQtr5O8GIPvNyDHYTKs1GSy9CmXKq/X8/f9KNzI HIYv08+kstna0w==; In-Reply-To: <87mshdjd2k.fsf@> (message from =?UTF-8?Q?Bj=C3=B6rn?= Bidar on Tue, 03 Dec 2024 12:06:11 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296366 Archived-At: > From: Björn Bidar > Cc: 74637@debbugs.gnu.org > Date: Tue, 03 Dec 2024 12:06:11 +0200 > > >> > That's an incompatible behavior change. Is that justified? How can > >> > we be sure that everyone agrees with your interpretation of this mode? > >> > >> All other view-file like modes behave like this, you view the file and > >> leave the file with q. > > > > That doesn't change the fact that view-mode didn't behave like that, > > until now. > > View-mode isn't change outside of the specific situation of opening a > file which isn't writable. It's still a significant change. Killing a buffer is not a minor think, and restoring it is not always easy, or even possible (e.g., the file could have been deleted in the meantime). My opinion is that if we install this, we need to provide some way of getting the previous behavior back, for those who may want it. Stefan and Andrea, WDYT?