From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Thu, 05 Dec 2024 08:22:18 +0200 Message-ID: <86zflay7hh.fsf@gnu.org> References: <86wmgfzhgc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11401"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, me@eshelyaron.com, 73862@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 05 07:23:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJ5Gr-0002pP-BH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Dec 2024 07:23:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJ5GR-0001lL-OF; Thu, 05 Dec 2024 01:23:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ5GQ-0001kt-Cl for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 01:23:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJ5GQ-00037z-47 for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 01:23:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=SsPjS6Kwsu+np490hYlLvxh646Uhvu2PocazNzpzZ9Y=; b=my3tIaxzgOMvu7+/gpkluXNBGhaHnsI6f9AoJJ/y8sEhargg4atu2Fl42APTTukNghmiuPVaxI8EuJiSgzEX5fev0LT4dwc1Bu0eyrE2Yrp6RJzS9NgCJ8NlW4YcStuYqD4bPM84FR1eKY5bZsjNuPO5tOKMMwVsMyYvPKGtfVHOw94VGqD/uTgWyPPX/m7ylTvBTaRBB8qTlMvAZDlMnXZnEFXgXXWmsRzA5PdKQy8VScaSVEmmvZq3u7l0sQFwD2xLKVEBvxjnWq8KnRdJJ09Cf/Km0i4qvNqNRBl1IDAAoTmSrMVSeA1s8I7CQTfpWdwOTlzK3ysJxYw/b0f0yA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJ5GP-0001X4-PI for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 01:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2024 06:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.17333797495835 (code B ref 73862); Thu, 05 Dec 2024 06:23:01 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 5 Dec 2024 06:22:29 +0000 Original-Received: from localhost ([127.0.0.1]:37833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ5Ft-0001W3-DE for submit@debbugs.gnu.org; Thu, 05 Dec 2024 01:22:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ5Fr-0001Vn-DD for 73862@debbugs.gnu.org; Thu, 05 Dec 2024 01:22:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ5Fl-00029X-Pz; Thu, 05 Dec 2024 01:22:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SsPjS6Kwsu+np490hYlLvxh646Uhvu2PocazNzpzZ9Y=; b=YzT65drH99AgVmBoMJKZ VZIbWR2zNbKqRl0z9NMF4xWp+8H1HUgQoeTkpp6Z9puE+3ubJTzxm8mpfPK+hZPnh52LrGOaGttB4 a6upU6Ec3F9WzowX85gIJWPAoDFvYC+8oUDcITcu8DwLqlhDO/BlcjBKNf1Qq5nPgOwK8pz7JOeRP jzRSSyvvA9KMYxN0HEVyR8DJD5n6DcpeZzOcU1IaGzxrvX22C4Py4vfi/p5XmwvVWlKGuZJtgRxle qTUGeNFzckqBga/4YgYN8iaUmt9YKZS6GcvXXTO6gTbTUQzot8oCgjgqpzBEIYzYbRqXlzLc87x8I crWPbZzIPGybZw==; In-Reply-To: (message from Aaron Jensen on Wed, 4 Dec 2024 19:06:26 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296441 Archived-At: > From: Aaron Jensen > Date: Wed, 4 Dec 2024 19:06:26 -0800 > Cc: Trevor Murphy , Eshel Yaron , 73862@debbugs.gnu.org > > You were able to reproduce what? I don't think you posted a recipe to reproduce the problem. Please > do, if at all possible, preferably starting from "emacs -Q". > > I didn't — I thought I mentioned that. I had intended to provide one as soon as I had a chance to, but it turns > out that Eshel encountered the same issue and provided a recipe (thank you, Eshel). The only difference in > my case is that face-remap-set-base is used, rather than face-remap-add-relative. > > As far as I can tell, this same bug occurs in the mode-line as well as the header-line. I.e., there was an > existing bug in the mode-line and it was replicated to the header-line after the two new faces were added. If what you see is the same as Eshel, I will ask you the same question: shouldn't you apply face-remapping to the 2 new faces instead of the 'header-line' face from which they both inherit? What happens if you do define remapping for those two new faces?