From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74642: 31.0.50; [Patch] Turn off current source line indicator when gdb buffer is killed Date: Thu, 12 Dec 2024 12:47:13 +0200 Message-ID: <86zfl1yy8e.fsf@gnu.org> References: <87wmgiy38x.fsf@163.com> <868qsy442u.fsf@gnu.org> <87ldwxy11t.fsf@163.com> <86ed2p2bgm.fsf@gnu.org> <87frn3yi04.fsf@163.com> <8634j31s75.fsf@gnu.org> <86ed2nz2jc.fsf@gnu.org> <878qsuy44r.fsf@163.com> <86ikryy35q.fsf@gnu.org> <874j3iy182.fsf@163.com> <86ed2jiq0v.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15927"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74642-done@debbugs.gnu.org To: diancheng_wang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 12 11:48:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLgk3-00041L-Hf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Dec 2024 11:48:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLgjp-0002Rw-8f; Thu, 12 Dec 2024 05:48:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLgjj-0002RE-8U for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2024 05:48:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLgji-0005R6-UA for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2024 05:48:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=64PqpZBtrwKxL3QqOh0A83AsJaqbIFL0GQvjsdPYGDM=; b=QKVigjnP+EQbrGVfNYmZPUOkz7qfDAgkCsi4cwXHubQw6t1gkxfmY+esVON6zazgb+Md2IgkFjfuMZBbJpr9qQTkYdsaYv4DJvwVdrIaHkYU95DyvsvngxFAuPSSchMQFgvMBW8VKMphu4JxuHxhQmS96RcCkTmmtMtVSi4YhF7NAVnVCPtwnkCY+qoP+EffBOXGzhTM4DjnniFCkWiQqPhRXu0+SkxvFP3LIUOg6mwYpZHK6rzjLdbudg7EWLdzR8qg9bTJaGlax2R/muWPqXUlYU4lqsWxfXf0Vcp8ieyDV2BKYRbYLAS7Gut/T3vhpe73BJZex9PBsRuIdq2nrQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLgji-0008FM-GC for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2024 05:48:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Dec 2024 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74642 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 74642@debbugs.gnu.org, eliz@gnu.org, diancheng_wang@163.com Original-Received: via spool by 74642-done@debbugs.gnu.org id=D74642.173400044831618 (code D ref 74642); Thu, 12 Dec 2024 10:48:02 +0000 Original-Received: (at 74642-done) by debbugs.gnu.org; 12 Dec 2024 10:47:28 +0000 Original-Received: from localhost ([127.0.0.1]:37800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLgj9-0008Dt-Bg for submit@debbugs.gnu.org; Thu, 12 Dec 2024 05:47:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLgj4-0008DZ-SY for 74642-done@debbugs.gnu.org; Thu, 12 Dec 2024 05:47:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLgiz-0004pE-22; Thu, 12 Dec 2024 05:47:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=64PqpZBtrwKxL3QqOh0A83AsJaqbIFL0GQvjsdPYGDM=; b=bBWv7RNQP/mT EcJR1BAbg0NYxfw3uaNEC0uzjTYaFhM6SlCgGuC7htYWe6KFFMB3nEZhS/p3a0MczoHuVKapY9J9g f0v0FyVA4JHBDc2JUo5We9YfVSz1bI7nph+L/+iAxyqhGfkwlydh49VkYEr8FZvsIyZ0h2dUaZfyY +8SZTS+auz+qWu7t+ZUC6kMfjKfr+i4zLQTL5ieXUGR7D9EbmcYOKGjjcjQOKd3n5aZjUbNhW770J 52CGuG8dpAyHzLdMAF+4KbicVyZRkhJAQeFL6xxRzceUVlPs4vbKjgl9/3avQaEyplddUuI+xmAsP rgsHMGZ7PT0aJYBJ9XSeeQ==; In-Reply-To: (message from diancheng_wang on Mon, 9 Dec 2024 09:27:42 +0800 (CST)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296902 Archived-At: > Date: Mon, 9 Dec 2024 09:27:42 +0800 (CST) > From: diancheng_wang > Cc: 74642@debbugs.gnu.org > > At 2024-12-07 21:25:20, "Eli Zaretskii" wrote: > > >> From: Diancheng Wang > >> Cc: 74642@debbugs.gnu.org > >> Date: Thu, 05 Dec 2024 16:37:33 +0800 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Diancheng Wang > >> >> Cc: 74642@debbugs.gnu.org > >> >> Date: Thu, 05 Dec 2024 15:34:44 +0800 > >> >> > >> >> > Crystal ball says that the regression was caused by the change you > >> >> > submitted (and I installed) in bug#73687. It added a call to > >> >> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel. > >> >> > Could you try reverting those changes and see if that solves the > >> >> > problem in Emacs 31? > >> >> > >> >> Yes, There is a regression in my patch: the arrow on the source line is > >> >> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30 > >> >> and Emacs 31 still have another issue: > >> >> gud-highlight-current-line-overlay is not destroyed when > >> >> "*gud-myprogram*" got killed. > >> > > >> > As I already wrote, I don't see the problem in Emacs 30: when I kill > >> > the *gud-myprogram* buffer, the arrow disappears. > >> > > >> >> To reproduce it, you need to evaluate (setq > >> >> gud-highlight-current-line t). > >> > > >> > So in Emacs 30 this only happens when gud-highlight-current-line is > >> > non-nil? > >> > >> Yes, the highlighted current source line in source file is not > >> un-highlighted when gud-highlight-current-line is non-nil. > >> > >> > > >> >> I updated my patch to fix this 2 issues, see attachment. > >> > > >> > Does this fix the problem with the current-line indicator (either on > >> > the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31? > >> > > >> > Thanks. > >> > >> This patch depends on my previous patch, which is commit in master branch: > >> > >> --8<---------------cut here---------------start------------->8--- > >> > >> commit bd5d84e5d3311e7ab4a7d0091d6c98365927d17a > >> Author: Diancheng Wang > >> Date: Tue Oct 8 11:11:24 2024 +0800 > >> > >> Stop highlighting current line when debuggee is running > >> > >> --8<---------------cut here---------------end--------------->8--- > >> > >> To apply this fix, Emacs 30 needs this commit. > > > >OK. But the master branch needs only your last patch, and does not > >need the original patch you posted in this bug report, is that right? > > Yes, that's right. Thanks. So I've now installed that patch on the master branch, and I'm therefore closing this bug.