From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74905: [PATCH] Implement search for nnvirtual Gnus groups Date: Wed, 18 Dec 2024 05:58:00 +0530 Message-ID: <86zfktesxb.fsf@gmx.net> References: <87jzc0a4cm.fsf@> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26901"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74905@debbugs.gnu.org To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 18 01:29:44 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNhwe-0006qV-9B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Dec 2024 01:29:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNhw2-00045v-7U; Tue, 17 Dec 2024 19:29:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNhvz-00045W-5X for bug-gnu-emacs@gnu.org; Tue, 17 Dec 2024 19:29:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNhvy-0002YQ-SI for bug-gnu-emacs@gnu.org; Tue, 17 Dec 2024 19:29:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=dA7mB9b/IgxY/VAIkAN78gbzBYlhMCn33ZBP9Juv97Y=; b=F+J4mbu/RDvG558CXc+HjHlY5Il0mcM02I9b5mP/gVXOhphvyix7JkIkoDalyErTDCui89E3WVFSh7T9roWNeTvn9qD0oPwazxjBET7tHfNsmKrt3I6TBETN6iaCzMTjboe1DIVCYv8VBloe7pHbl4S4AoazpmdnYUPH8AgLgbuMICuDdLEPMd/gClpTBaG/EC2ldv1i8VtZ+TcQsrE9nfrieoYkvP1VslBOJIQXVkgxL+LwS2jhSBZQaJ+il9WieyV3f4ytqoQxA0RSujVnDk5xdC9rRlkWI7jcVERr28IT3iLf5x7G56NusK3GWM0jRBwvyBh6sPP5YMp1Sokd4A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNhvy-0007Bi-Il for bug-gnu-emacs@gnu.org; Tue, 17 Dec 2024 19:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2024 00:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74905-submit@debbugs.gnu.org id=B74905.173448170127536 (code B ref 74905); Wed, 18 Dec 2024 00:29:02 +0000 Original-Received: (at 74905) by debbugs.gnu.org; 18 Dec 2024 00:28:21 +0000 Original-Received: from localhost ([127.0.0.1]:60816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNhvI-0007A2-LL for submit@debbugs.gnu.org; Tue, 17 Dec 2024 19:28:20 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:42505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNhvH-00079o-8E for 74905@debbugs.gnu.org; Tue, 17 Dec 2024 19:28:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1734481690; x=1735086490; i=jimjoe@gmx.net; bh=dA7mB9b/IgxY/VAIkAN78gbzBYlhMCn33ZBP9Juv97Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=M7tYD8BkSIoTcj5HzAoAxNIBSa8601m0Pns8giXmQ3Pxm/cLAKdPCxbzZF87qpDi ZAj8x8lC2Hlbzl50DnhgpVTHhPvlUVFu6Z2JYeAm9dTni3I0tzAFRv1PY+Ao9wNcx KThjBbFAzYB04HQ9eAz41sgNH6r7NUS0wNX1ejYp9FwHt2L2uu1WCWRbtcAuDFdGF KIwQTGC8r43rnCVRdKqV95MYKqtBDKozYUekle+/QmHN7k1QC9suKhtKQ+f/2+0l/ vtHuSIAMs+GDenjGDHdIuKH7tf+XnPaJVK9Sx4dEktFLVp0tSVA95K5Oc4v815czm cwmGApOJiZcj+sEqWQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-3493 ([42.108.28.196]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mlf4c-1tnj591n7q-00k5DP; Wed, 18 Dec 2024 01:28:10 +0100 In-Reply-To: <87jzc0a4cm.fsf@> ("=?UTF-8?Q?Bj=C3=B6rn?= Bidar"'s message of "Mon, 16 Dec 2024 01:55:37 +0200") Importance: high X-Provags-ID: V03:K1:ZCdkdMUGVUFInIPu2TiNV3c8/yMDIIGO/yg06yh/ankIzokGmjD leVHAxoYrxTexFVm7K37SYeofXNF+boLTMzFzy10tisgYl1ZpTCD5vg4lHUiZlmLlXyqUjU mzQNVZbsPcHkDcX0TIPWGCrAJzIR6jkL70Bndr4BZ77zmdzsGXseZIAALodCgUOf46qaXoI RD8uDVoHLjd6DoE7jjzTA== UI-OutboundReport: notjunk:1;M01:P0:JVh4GxBO/LM=;kI6qpVglZsQVe0eHmtysZOdelW0 yPdXHH4ncPwXQVCVJOmB/heaidyt+0QVChE1yx71EbThCmAap5qz2ap4/894Zg2Z0j89MVrRv QezyWgTivTMJc6/gB+arynxqYy+l9tz3VaiycrW762Hxm9GMHbpz8RdTrCGZL7H1LgRgKBkGN D05iN3/4bZpULMQPrt2Q78rGwDDymwXiguxVK18Y+BMVzQvdUa6xKWkjHkvnDJk6xnQG+TRuj KHcaHvskm5R/BteD9hSxjlmoYqb6fMNPjYWotW6PHHRW2lTU8VMGhb+DTIP/SpKLVCwfmdjvN 8YVbJL8U9iRT+8jOA3jsaiwa0jLrK/wti0POJsWs0QgqUImu2tHTS9fg0+PpgyGmbQ4cbd+rF Ic8LbRcaoe7Cq7+lQW8CL2MCHDZuJUCT28gTzUlubwmrYMRj3qohFjjPXZSNHgewrBiOqNSAr 6hFX4/z9ZZdM8uZz49PLS0BquZQ1eF5uJc1CLDHljXzYN3N0gyU1gPKB2VNDTkaUjkmYWHMAP CZOM5aZkPt94fTmi/XDJjJji5SzjJcn6RwU6JIg0NH56uXKLRwxbrA/RdmUtHqgOLgqvhHKJT UeQl2xN/TvHsyZBYrDw9z0cYR+3CIfZT7lFwSmpqHJGQKfjfeF/iOcjiTQq4ZtcLMRJyuSIBk lqCUVgixGK8DNI5wW+lTlmwhqFM0r34o4VB5Sg2o4n0jd4Ug7nmCm6tZgRqM81Pxy46Z6IgyW rTdnJuptq7a3LjSIsrXiV5rdNFFHwElRPSHSdNFh7h3NGj7FINt3UYxPgnCr/3OoZJ0pmQ9k X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297321 Archived-At: Bj=C3=B6rn Bidar wrote: > This patch implements search for nnvirtual. I'm using publi-inbox's > with nnvirtual to group each group into one. > However searching wasn't possible in these nnvirtual groups. > I implemented gnus-search-run-search based on the existing > nnselect gnus-search-run-search function. Thanks! I haven't looked into it, but here are some quick comments: > I'm looking for feedback on the patch. I don't exactly know how > the search function is called when multiple groups of the same type > are > involved. For nnvirtual each group is its on server, does that mean > the > function will be always called only for each group? In that case > everything should be good. That seems to be the case: see gnus-group-read-ephemeral-search-group and gnus-group-make-search-group. > +(deffoo nnvirtual-request-list (&optional server) > + (when (nnvirtual-possibly-change-server server) > + (with-current-buffer nntp-server-buffer > + (erase-buffer) > + (dolist (group nnvirtual-component-groups) > + (insert (format "%S 0 1 y\n" group)))) > + t)) Did you check if gnus-start.el#L1801 withstands this? It seems to me to assume that nnvirtual doesn't have -request-list. --