From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75020: [PATCH] Fix make-separator-line for ttys not supporting underline Date: Sun, 22 Dec 2024 14:20:16 +0200 Message-ID: <86zfkn6ha7.fsf@gnu.org> References: <8634ig6sb9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27934"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75020@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 22 13:23:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPKzP-00079k-Ll for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Dec 2024 13:23:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPKzA-0003B3-5l; Sun, 22 Dec 2024 07:23:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPKz8-0003Ae-C3 for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 07:23:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPKz7-0002Bd-Ug for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 07:23:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=zZ8ClwAEuS8A6Fk7yL/4h0HuhEy0cXwSHgC4rwbtCsE=; b=InBf7K2ZUPUcfcdW6KPHSm3HsO337VCwzLNuK0sFrMposHFiIjzUFECsuiiraZ0BWILPyH8M4p8ZhVcA5m80oldfP8o6dPPGgSLQ0bx6JBLBUqub0m1Sv3zOmw6Om0BHayZ2oywLkEvGQTXLzIeIg6M2QZKUxMZylZycBzmJTEGADpTsTXVWicQWef2flicdXEShoO4G4dIdTgU+EDIuT4Y3FjRf5LcGcuKNnphSsL5DM3ndmhT+cv5RXFYtI6qKQTTZOdeOssIZQPK6xNgb3ebFNrT8hg1I0ic7wYyPftRj1YkDKqDokLU5uBS3D9MzCkk784Z3uyQYNLd5MNGD0Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPKz7-00014H-OS for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 07:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Dec 2024 12:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75020 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75020-submit@debbugs.gnu.org id=B75020.17348701564045 (code B ref 75020); Sun, 22 Dec 2024 12:23:01 +0000 Original-Received: (at 75020) by debbugs.gnu.org; 22 Dec 2024 12:22:36 +0000 Original-Received: from localhost ([127.0.0.1]:49297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPKyh-00013B-ST for submit@debbugs.gnu.org; Sun, 22 Dec 2024 07:22:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPKyg-00012z-CD for 75020@debbugs.gnu.org; Sun, 22 Dec 2024 07:22:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPKwT-0001uX-SY; Sun, 22 Dec 2024 07:20:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zZ8ClwAEuS8A6Fk7yL/4h0HuhEy0cXwSHgC4rwbtCsE=; b=VABLadpqiGWGUkAMaWIF cRmAqPCvcZ/KvciWlqnlsBiAa+v4ZKG9cwGV5fKFRYrrruH8sBmOvylZo4eSYhOGIyh8tHjqe4msc /Uh1a6+URHLnnc1FxlVDJSgYZt1+VzduZdJ5jNvoNbm9DWTM3cEZ3KY6zeMK6cn0XGT5fZndxJH10 26P9QdI2kRnEmOEbrXTwl9WOyeI5Sx1dY9Ngdq4WsPI7vx4mbuZ5vwMFwcdIZbMTW3iIV+15z/rBy YML5nkook/BNRHcxILyWJsG+pX9nIBzH6BjBTyYzuhTUtx0xbvB9o1JNHz6X426RThCwG/JQbe6J+ TSz5nBufgA1FlA==; In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Sun, 22 Dec 2024 09:49:34 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297597 Archived-At: > From: Gerd Möllmann > Cc: 75020@debbugs.gnu.org > Date: Sun, 22 Dec 2024 09:49:34 +0100 > > Eli Zaretskii writes: > > > Thanks. But I'm not sure this is for make-separator-line to decide. > > For example, after applying the patch, using this recipe: > > > > M-: (insert (make-separator-line)) RET > > M-x display-line-number-mode RET > > > > we will again get a too-long separator line. And with this recipe: > > > > M-x display-line-number-mode RET > > M-: (insert (make-separator-line)) RET > > M-x display-line-number-mode RET > > > > we will get a too-short separator line. > > > > So arguably, in these special cases, the caller should pass the > > required length as the optional argument, because only the caller > > knows the context in which the function is called and the purpose for > > which the separator will be used. Which would mean the default of > > using window-width is correct. > > > > Does this make sense? > > Yes, makes sense. > > I noticed this too now with C-h f context-menu-mode, for example. > If the separator line size depends on the window which it currently > does, one gets different results. > > And when the help buffer is shown in a different window, and in my case > to the left or right, it's almost always too long and wraps to 2 or 3 > lines. It looks pretty weird. So I think we need to have bug reports for those applications where this happens, in particular in C-h. That's where this should be fixed. > But whatever, I'll close the bug in a minute. Thanks! Thanks.