From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alain Schneble Newsgroups: gmane.emacs.bugs Subject: bug#22789: 25.1.50; In last master build https connections stop working Date: Wed, 2 Mar 2016 23:02:31 +0100 Message-ID: <86y4a0lers.fsf@realize.ch> References: <864mcyo14y.fsf@Lenovo-PC.i-did-not-set--mail-host-address--so-tickle-me> <86si0euizj.fsf@realize.ch> <871t7xhj7t.fsf@gnus.org> <86oab1vjm9.fsf@realize.ch> <86d1rhpvcq.fsf@realize.ch> <834mctbitq.fsf@gnu.org> <868u25p3m2.fsf@realize.ch> <83io18ahya.fsf@gnu.org> <86y4a3on6f.fsf@realize.ch> <87oaazg7fv.fsf@gnus.org> <86twkro0vr.fsf@realize.ch> <87mvqjgqqg.fsf@gnus.org> <86k2lnnlwy.fsf@realize.ch> <831t7u9826.fsf@gnu.org> <87vb56vkti.fsf@gnus.org> <83ziui6w1s.fsf@gnu.org> <87d1rcrc36.fsf@gnus.org> <86egbsn1fn.fsf@realize.ch> <87y4a0pu71.fsf@gnus.org> <86a8mgn00c.fsf@realize.ch> <8660x4mwvp.fsf@realize.ch> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1456956266 22657 80.91.229.3 (2 Mar 2016 22:04:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Mar 2016 22:04:26 +0000 (UTC) Cc: j_l_domenech@yahoo.com, 22789@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 02 23:04:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1abEsM-0001ZD-C7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Mar 2016 23:04:10 +0100 Original-Received: from localhost ([::1]:59302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abEsL-0000Mv-IN for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Mar 2016 17:04:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abEsH-0000Ly-Sn for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2016 17:04:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abEsE-0006al-Mg for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2016 17:04:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abEsE-0006aa-Jy for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2016 17:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1abEsE-00042Z-77 for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2016 17:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alain Schneble Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Mar 2016 22:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22789 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22789-submit@debbugs.gnu.org id=B22789.145695620015482 (code B ref 22789); Wed, 02 Mar 2016 22:04:02 +0000 Original-Received: (at 22789) by debbugs.gnu.org; 2 Mar 2016 22:03:20 +0000 Original-Received: from localhost ([127.0.0.1]:58216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1abErX-00041e-Rh for submit@debbugs.gnu.org; Wed, 02 Mar 2016 17:03:20 -0500 Original-Received: from clientmail.realize.ch ([46.140.89.53]:1319) by debbugs.gnu.org with smtp (Exim 4.84) (envelope-from ) id 1abErW-00041Q-4E for 22789@debbugs.gnu.org; Wed, 02 Mar 2016 17:03:18 -0500 Original-Received: from rintintin.hq.realize.ch.lan.rit ([192.168.0.105]) by clientmail.realize.ch ; Wed, 2 Mar 2016 23:02:52 +0100 Original-Received: from MYNGB (192.168.66.64) by rintintin.hq.realize.ch.lan.rit (192.168.0.105) with Microsoft SMTP Server (TLS) id 15.0.516.32; Wed, 2 Mar 2016 23:02:45 +0100 In-Reply-To: <8660x4mwvp.fsf@realize.ch> (Alain Schneble's message of "Wed, 2 Mar 2016 21:46:02 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (windows-nt) X-ClientProxiedBy: rintintin.hq.realize.ch.lan.rit (192.168.0.105) To rintintin.hq.realize.ch.lan.rit (192.168.0.105) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114312 Archived-At: --=-=-= Content-Type: text/plain Alain Schneble writes: > - If I add (setq alt "[empty alt]") on top of `shr-put-image', then > loading of images works quite well. Also with https connections. (I > do not say that the issue with the loop progress is not there...) Here is a patch to fix the empty-range issue when inserting non-cached images in eww: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename="0001-Fix-insertion-of-non-cached-images-in-eww.patch" Content-Description: Patch >From ebf4b78ff53b92d99ef3ca771ff0d592d80b1c3d Mon Sep 17 00:00:00 2001 From: Alain Schneble Date: Wed, 2 Mar 2016 22:49:32 +0100 Subject: [PATCH] Fix insertion of non-cached images in eww * lisp/net/shr.el (shr-tag-img): Construct a non-empty range to pass to shr-image-fetched, to indicate where to insert the image. Fixes the issue introduced with commit 80852f843e69b81618f29cfb9aa4b074946cb3c4. --- lisp/net/shr.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/shr.el b/lisp/net/shr.el index c469e69..e463c7e 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1499,7 +1499,7 @@ The preference is a float determined from `shr-prefer-media-type'." (insert " ") (url-queue-retrieve (shr-encode-url url) 'shr-image-fetched - (list (current-buffer) start (set-marker (make-marker) (1- (point))) + (list (current-buffer) start (set-marker (make-marker) (point)) (list :width width :height height)) t t))) (when (zerop shr-table-depth) ;; We are not in a table. -- 2.6.2.windows.1 --=-=-= Content-Type: text/plain And by the way, with this fix, disabling (url-store-in-cache image-buffer) in `shr-image-fetched' does no longer break loading of images, as I would have expected before. --=-=-=--