From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper Date: Tue, 11 Aug 2020 19:27:00 +0100 Message-ID: <86y2mlf37v.fsf@gmail.com> References: <74235afc-7043-1da7-7c71-07f0ca23b9fd@cs.ucla.edu> <83r26mv53z.fsf@gnu.org> <87ft8vbow1.fsf@gnus.org> <87v9hq4ppp.fsf@gnus.org> <83k0y544lf.fsf@gnu.org> <835z9pp16x.fsf@gnu.org> <8525b631-b24e-ce89-6314-741449ca8403@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9123"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt) To: 36597@debbugs.gnu.org Cancel-Lock: sha1:hkISmRHXmxSX+lNbyR/POT7Xr6s= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 11 20:28:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5Z0L-0002IO-1U for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 20:28:09 +0200 Original-Received: from localhost ([::1]:54328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5Z0K-0002cO-3f for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 14:28:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5Z0E-0002bd-7t for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 14:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58346) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5Z0D-0006iO-VG for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 14:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5Z0D-0003rM-QR for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 14:28:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Aug 2020 18:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.159717043514779 (code B ref -1); Tue, 11 Aug 2020 18:28:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Aug 2020 18:27:15 +0000 Original-Received: from localhost ([127.0.0.1]:41659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5YzT-0003qI-Dc for submit@debbugs.gnu.org; Tue, 11 Aug 2020 14:27:15 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:55844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5YzR-0003q9-HG for submit@debbugs.gnu.org; Tue, 11 Aug 2020 14:27:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5YzR-0002CT-Aq for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 14:27:13 -0400 Original-Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:37966 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5YzP-0006dq-MK for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 14:27:12 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1k5YzI-0000yp-N4 for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 20:27:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/11 14:15:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 20 X-Spam_score: 2.0 X-Spam_bar: ++ X-Spam_report: (2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184683 Archived-At: On Tue 11 Aug 2020, Paul Eggert wrote: > On 8/11/20 10:00 AM, Eli Zaretskii wrote: >>> I suggest going back to Fmake_vector (h->hash, Qnil), as in the >>> attached patch. It's shorter, and it actually compiles. >> Yes, I did that, thanks. > > The compilation issue was due to pdumper enabling -Wconversion, which causes > more trouble than it cures (but that is a different topic). I worked around > the glitch by installing the attached further patch, which should also help > explain the motivation for make_nil_vector. Eli's fixes have addressed issues with the MinGW toolchains, but Mingw64 64bit builds are still broken: C:/emacs/git/emacs/master/src/pdumper.c: In function 'dump_read_all': C:/emacs/git/emacs/master/src/pdumper.c:5078:60: error: conversion from 'size_t' {aka 'long long unsigned int'} to 'unsigned int' may change value [-Werror=conversion] 5078 | ssize_t chunk = read (fd, (char *) buf + bytes_read, chunk_to_read); | ^~~~~~~~~~~~~