From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Fri, 08 Oct 2021 14:49:37 +0100 Message-ID: <86y273k4ni.fsf@gmail.com> References: <86tuhvmtpl.fsf@runbox.com> <877deqec10.fsf@gnus.org> <83fste2u4i.fsf@gnu.org> <87ily94662.fsf@gnus.org> <86h7dszgv2.fsf@gmail.com> <87tuhsqypa.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13168"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (windows-nt) To: 51037@debbugs.gnu.org Cancel-Lock: sha1:V8Wm5vq+dt1ONqhq86DCldWvIdE= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 08 15:52:35 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYqId-0003Fe-9T for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 15:52:35 +0200 Original-Received: from localhost ([::1]:53316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYqIc-0003Rk-92 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 09:52:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYqGA-0007Wa-JE for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 09:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYqGA-0004Xv-A0 for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 09:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYqGA-0004KP-8N for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 09:50:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <86tuhvmtpl.fsf@runbox.com> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Oct 2021 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163370098916613 (code B ref -1); Fri, 08 Oct 2021 13:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Oct 2021 13:49:49 +0000 Original-Received: from localhost ([127.0.0.1]:49494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYqFx-0004Jt-7L for submit@debbugs.gnu.org; Fri, 08 Oct 2021 09:49:49 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:48914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYqFv-0004Jl-J9 for submit@debbugs.gnu.org; Fri, 08 Oct 2021 09:49:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYqFv-0006YO-9t for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 09:49:47 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:39240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYqFt-0003dI-Pv for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 09:49:46 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mYqFr-0009rU-Gt for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 15:49:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216718 Archived-At: On Fri 08 Oct 2021, Lars Ingebrigtsen wrote: > Andy Moreton writes: > >> Isn't that what ert-batch-backtrace-right-margin is for ? >> >> (defcustom ert-batch-backtrace-right-margin 70 >> "Maximum length of lines in ERT backtraces in batch mode. >> Use nil for no limit (caution: backtrace lines can be very long)." >> :type '(choice (const :tag "No truncation" nil) integer)) >> >> Also the TEST_BACKTRACE_LINE_LENGTH environment variable can be >> used to set it (see test/Makefile.in). > > Right. But ert will still shorten "internally" with print-length etc > before chopping the lines to 70 characters. Here's with a longer value: > > est test-ensure-list2 backtrace: > signal(error ("(\"foo\" \"foo\" \"foo\" \"foo\" \"foo\" \"foo\" \"foo\" \"foo\" \"...")) > error("%S" ("foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" > "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" > "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" > "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" "foo" > "foo" ...)) > (closure (t) nil (error "%S" (make-list 100 "foo")))() > > Note the "..." at the end of the foo list -- that's from print-length. Good point. The truncation would not be so bothersome if there were separate console and logfile streams (with the truncation only happening in the console stream, and the full details in the logfile stream). Anything that can make failed tests easier to diagnose is a useful improvement. AndyM