From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Sat, 12 Feb 2022 19:09:00 +0200 Organization: LINKOV.NET Message-ID: <86y22gypxn.fsf@mail.linkov.net> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> <871r1zm7ji.fsf@gmail.com> <87wnjrkrwd.fsf@gmail.com> <86ilv8pnf3.fsf@mail.linkov.net> <87k0fouzxs.fsf@gmail.com> <86sftumahu.fsf@mail.linkov.net> <87pmouw9qr.fsf@gmail.com> <87a6fuvzj9.fsf@gmail.com> <86bkzli245.fsf@mail.linkov.net> <875yptas9m.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20261"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Matthias Meulien , 51809@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 12 18:16:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIw0Y-00056W-9M for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Feb 2022 18:16:26 +0100 Original-Received: from localhost ([::1]:60744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIw0W-00087O-QQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Feb 2022 12:16:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIw0A-000840-Rz for bug-gnu-emacs@gnu.org; Sat, 12 Feb 2022 12:16:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nIw0A-0002W6-IZ for bug-gnu-emacs@gnu.org; Sat, 12 Feb 2022 12:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nIw0A-0006sF-Ez for bug-gnu-emacs@gnu.org; Sat, 12 Feb 2022 12:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Feb 2022 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.164468615826408 (code B ref 51809); Sat, 12 Feb 2022 17:16:02 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 12 Feb 2022 17:15:58 +0000 Original-Received: from localhost ([127.0.0.1]:35552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIw06-0006rs-Kt for submit@debbugs.gnu.org; Sat, 12 Feb 2022 12:15:58 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:40631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIw03-0006rF-A2 for 51809@debbugs.gnu.org; Sat, 12 Feb 2022 12:15:55 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 438FE1C0002; Sat, 12 Feb 2022 17:15:47 +0000 (UTC) In-Reply-To: <875yptas9m.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 05 Feb 2022 23:00:05 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226734 Archived-At: >>> I see one problem: Once one has some default state configured for Diff >>> mode, it applies to patch embedded in Gnus Article buffers, but there >>> the outline-minor-mode keymap isn't active and there's no way to toggle >>> headings visibility... No idea how to improve this situation... >> >> Oh, I see now it's a real problem. Some patches are not displayed >> because their hunks are hidden. Fro example, a patch from bug#53770 >> attached below, becomes hidden with these settings: >> >> (add-hook 'diff-mode-hook >> (lambda () >> (setq-local outline-default-state 2) >> (outline-minor-mode 1))) > > Hm, that's not good... Perhaps we could just disable outline on the > Gnus level when displaying parts? I'm still not sure about disabling outlines in Gnus because when the user configured to hide outlines e.g. with long lines, then it makes sense to hide long lines in Gnus too. But the problem with the reported attached file is different: in that file outlines are never displayed even outside of Gnus. This is because the diff format is slightly different, but `outline--show-headings-up-to-level' first hides all outlines, but then fails to unhide them back. Matthias, could you please check what is wrong with the reported diff file and why vasibility of its outlines can't be changed?