unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Magnus Nilsson <magnus.nilsson@alumni.chalmers.se>
Cc: 56374@debbugs.gnu.org
Subject: bug#56374: 27.2; Occur with non-contiguous regions
Date: Mon, 04 Jul 2022 09:31:17 +0300	[thread overview]
Message-ID: <86y1x9fky2.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAH027sW7wh5GmNzo9GpdkSsQAO0zvkWPwaC-+Yo9qwScVHmDwQ@mail.gmail.com> (Magnus Nilsson's message of "Mon, 4 Jul 2022 00:37:58 +0200")

> In the help text for 'occur' it indicates that it should be able to work
> on non-contiguous regions (i.e., a list of cons cells on the form (START
> . END)). However, when I tried this in both Emacs 27 and 28, this
> doesn't work when I mark a rectangular region. It only catches
> occurrances found within the bounds of the first cons cell.

Like bug#14013 now has a patch that implements support for any regexp
including "^.*$" on a non-contiguous region, occur should be improved
to use the same search function.  (Also all artificial restrictions
on handling only the first cons cell in occur should be lifted.)

> My intention was to override (region-bounds) within a let statement to
> return a non-contiguous region of interest (in the form of a list of
> cons cells) and let 'occur' work on that non-contiguous
> region. Unfortunately, this didn't work out as I planned. It would be
> neat if this could be fixed for upcoming versions.

Do you expect that 'occur' should accept a non-contiguous region
in its argument REGION?  This is not how perform-replace works.
The query-replace commands send the boolean value of
'(region-noncontiguous-p)' to perform-replace argument
'region-noncontiguous-p', then perform-replace extracts it with
'(funcall region-extract-function 'bounds)'.

Do you agree that 'occur' could do the same?





  reply	other threads:[~2022-07-04  6:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-03 22:37 bug#56374: 27.2; Occur with non-contiguous regions Magnus Nilsson
2022-07-04  6:31 ` Juri Linkov [this message]
2022-07-04  7:12   ` Magnus Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y1x9fky2.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=56374@debbugs.gnu.org \
    --cc=magnus.nilsson@alumni.chalmers.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).