From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60210: 30.0.50; tab-bar height not recalculated when face changes Date: Mon, 26 Dec 2022 19:29:01 +0200 Organization: LINKOV.NET Message-ID: <86y1qurs4i.fsf@mail.linkov.net> References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12237"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 60210@debbugs.gnu.org, gabriel376@hotmail.com, Eli Zaretskii To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 26 18:36:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p9rOe-0002yK-Vm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Dec 2022 18:36:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p9rOO-0005hT-LE; Mon, 26 Dec 2022 12:36:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9rON-0005ex-52 for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 12:36:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p9rOM-0001N5-OT for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 12:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p9rOM-0002wG-5q for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 12:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Dec 2022 17:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60210 X-GNU-PR-Package: emacs Original-Received: via spool by 60210-submit@debbugs.gnu.org id=B60210.167207611411221 (code B ref 60210); Mon, 26 Dec 2022 17:36:02 +0000 Original-Received: (at 60210) by debbugs.gnu.org; 26 Dec 2022 17:35:14 +0000 Original-Received: from localhost ([127.0.0.1]:54050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9rNZ-0002uu-Ko for submit@debbugs.gnu.org; Mon, 26 Dec 2022 12:35:13 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:49669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9rNX-0002ue-SM for 60210@debbugs.gnu.org; Mon, 26 Dec 2022 12:35:12 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 31BD260009; Mon, 26 Dec 2022 17:35:00 +0000 (UTC) In-Reply-To: (Gregory Heytings's message of "Mon, 26 Dec 2022 13:36:20 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251911 Archived-At: >>>> I doubt the font-related changes are relevant, but bisecting will be >>>> welcome. >>> >>> Indeed, the culprit is 5db4ec20fe. >>> >>> Patch attached. >> >> Thanks, this LGTM. If you tested this with tab bars of more than >> a single line, including when tabs are removed so a single line is once >> again long enough, please install on the release branch. > > I did test it, but I don't use tab bars, so I'm not 110% sure. Juri, could > you please test the patch? Thanks for the patch. I tested it in emacs-29 with tab-bar-lines > 1 and see no problems.