From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#61308: 28.2; icomplete --- Error in post-command-hook: wrong-type-argument Date: Thu, 09 Feb 2023 20:09:34 +0200 Organization: LINKOV.NET Message-ID: <86y1p6pv6p.fsf@mail.linkov.net> References: <87wn4vh6b9.fsf@gmail.com> <86cz6k1v3a.fsf@mail.linkov.net> <87a61n6c8q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4034"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 61308@debbugs.gnu.org To: Fernando de Morais Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 09 19:11:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQBOU-0000pE-C7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Feb 2023 19:11:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQBNz-0006fr-OO; Thu, 09 Feb 2023 13:11:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQBNu-0006ct-TL for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 13:11:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQBNu-00056X-GI for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 13:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQBNu-0000ui-Bv for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 13:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Feb 2023 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61308 X-GNU-PR-Package: emacs Original-Received: via spool by 61308-submit@debbugs.gnu.org id=B61308.16759662373469 (code B ref 61308); Thu, 09 Feb 2023 18:11:02 +0000 Original-Received: (at 61308) by debbugs.gnu.org; 9 Feb 2023 18:10:37 +0000 Original-Received: from localhost ([127.0.0.1]:33671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQBNU-0000ts-Km for submit@debbugs.gnu.org; Thu, 09 Feb 2023 13:10:36 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:45569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQBNS-0000tK-EW; Thu, 09 Feb 2023 13:10:35 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id A0122240008; Thu, 9 Feb 2023 18:10:26 +0000 (UTC) In-Reply-To: <87a61n6c8q.fsf@gmail.com> (Fernando de Morais's message of "Wed, 08 Feb 2023 19:09:09 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255246 Archived-At: close 61308 30.0.50 thanks >> diff --git a/lisp/icomplete.el b/lisp/icomplete.el >> index 014f38b2024..97457832e2c 100644 >> --- a/lisp/icomplete.el >> +++ b/lisp/icomplete.el >> @@ -686,6 +686,8 @@ icomplete-exhibit >> Should be run via minibuffer `post-command-hook'. >> See `icomplete-mode' and `minibuffer-setup-hook'." >> (when (and icomplete-mode >> + ;; Check if still in the right buffer (bug#61308) >> + (or (window-minibuffer-p) completion-in-region--data) >> (icomplete-simple-completing-p)) ;Shouldn't be necessary. >> (let ((saved-point (point))) >> (save-excursion > > This solved the problem, thank you! 🤝 > > I hope this path gets merged upstream. Now merged to master. Thanks for the bug report.