From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 62749@debbugs.gnu.org, Oleksandr Gavenko <gavenkoa@gmail.com>
Subject: bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer
Date: Tue, 16 May 2023 19:44:25 +0300 [thread overview]
Message-ID: <86y1lomh92.fsf@mail.linkov.net> (raw)
In-Reply-To: <6241918f-0933-7086-e3e8-d2b2df62c302@gutov.dev> (Dmitry Gutov's message of "Tue, 16 May 2023 14:46:36 +0300")
>>> After bisecting my long .emacs config I pinpointed the culprit:
>>>
>>> (which-func-mode 1)
>>
>> Maybe 'diff-syntax-fontify' could have a similar list of minor modes
>> that should be ignored. Then such a list should at least contain
>> 'which-func-mode' by default.
>
> Do you mean that it's not feasible to fix the behavior when which-func-mode
> is enabled?
After debugging I realized it's not related to diff-font-lock-syntax.
The problem is that 'which-func-mode' is enabled in diff-mode.
'which-function' calls 'add-log-current-defun' that calls
'add-log-current-defun-function' that is 'diff-current-defun'
in diff-mode. Finally, 'diff-find-source-location' visits
the source files without killing them afterwards.
I guess this is related to another annoying bug: after every commit need
to spend much time killing all buffers created by the commit command.
prev parent reply other threads:[~2023-05-16 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 12:11 bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer Oleksandr Gavenko
2023-04-10 12:14 ` Oleksandr Gavenko
2023-04-10 22:23 ` Dmitry Gutov
2023-05-14 10:59 ` Oleksandr Gavenko
2023-05-15 16:46 ` Juri Linkov
2023-05-16 11:46 ` Dmitry Gutov
2023-05-16 16:44 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y1lomh92.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=62749@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=gavenkoa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).