unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: casouri@gmail.com, 69405@debbugs.gnu.org
Subject: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests
Date: Mon, 26 Feb 2024 15:59:12 +0200	[thread overview]
Message-ID: <86y1b7uy1b.fsf@gnu.org> (raw)
In-Reply-To: <A6CDAB98-D99D-490F-827B-89A190198E58@gmail.com> (message from Mattias Engdegård on Mon, 26 Feb 2024 14:36:39 +0100)

> Cc: Yuan Fu <casouri@gmail.com>
> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Mon, 26 Feb 2024 14:36:39 +0100
> 
> The .emacs.d/tree-sitter/ directory isn't searched when running tests non-interactively. The Makefile sets HOME to /nonexistent, which is correct but has the unfortunate side-effect of not running all the tests properly even with the compiled grammars installed.
> 
> The attached patch adds an environment variable, EMACS_TREE_SITTER_DIR, and sets it in the Makefile. I didn't bother documenting it because it's only intended for use in our own tests.

Can't we do that in the test harness, instead of introducing
test-suite dependencies into the built Emacs binary?  For example, how
about adding to tree-sitter-extra-load-path in treesit-tests.el
instead?

Thanks.





  reply	other threads:[~2024-02-26 13:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 13:36 bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests Mattias Engdegård
2024-02-26 13:59 ` Eli Zaretskii [this message]
2024-02-26 16:26   ` Mattias Engdegård
2024-02-26 16:52     ` Eli Zaretskii
2024-02-26 18:07       ` Mattias Engdegård
2024-02-26 21:34         ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y1b7uy1b.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=69405@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).