unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 64830@debbugs.gnu.org, acm@muc.de, stefankangas@gmail.com
Subject: bug#64830: 30.0.50 C++ treesitter mode no coloration
Date: Thu, 29 Aug 2024 09:01:08 +0300	[thread overview]
Message-ID: <86y14fg95n.fsf@gnu.org> (raw)
In-Reply-To: <F0A10E0E-CAA2-487D-9696-517EDD9E8452@gmail.com> (message from Yuan Fu on Wed, 28 Aug 2024 21:54:26 -0700)

> From: Yuan Fu <casouri@gmail.com>
> Date: Wed, 28 Aug 2024 21:54:26 -0700
> Cc: Stefan Kangas <stefankangas@gmail.com>,
>  Alan Mackenzie <acm@muc.de>,
>  64830@debbugs.gnu.org
> 
> Ah, thanks for the review! TIL. Here’s the revised patch.

A few more nits:

> +  const char *sym;
> +  dynlib_addr((void (*) (void)) langfn, &loaded_lang.filename, &sym);
               ^^
We leave one space between the function name and the opening paren.
Also, do you really need the type-cast for langfn?  Do you get
compiler warnings if you remove the cast?

> +DEFUN ("treesit-grammar-location", Ftreesit_grammar_location,
> +       Streesit_grammar_location,
> +       1, 1, 0,
> +       doc: /* Return the path to the grammar file for LANGUAGE.
                             ^^^^
"Path" again.  I suggest "absolute file name" instead.

> +If LANGUAGE isn't loaded yet, load it first.  If the langauge can't be
> +loaded or the path couldn't be found, return nil.  */)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I suggest "or the file name couldn't be determined".

Thanks.





  reply	other threads:[~2024-08-29  6:01 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24  9:13 bug#64830: 29.1; C++ treesitter mode no coloration David Come
2023-07-24 12:32 ` Eli Zaretskii
2024-08-14 17:35 ` bug#64830: 30.0.50 " Alan Mackenzie
2024-08-15  5:25   ` Eli Zaretskii
2024-08-16 16:44     ` Alan Mackenzie
2024-08-16 17:40       ` Eli Zaretskii
2024-08-16 17:45         ` Eli Zaretskii
2024-08-16 18:06           ` Alan Mackenzie
2024-08-16 18:27             ` Eli Zaretskii
2024-08-20  3:46               ` Yuan Fu
2024-08-24 18:35                 ` Yuan Fu
2024-08-24 19:38                   ` Alan Mackenzie
2024-08-24 20:43                     ` Yuan Fu
2024-08-25  2:19                       ` Alan Mackenzie
2024-08-25  4:54                         ` Eli Zaretskii
2024-08-25 12:08                           ` Alan Mackenzie
2024-08-25 12:17                             ` Eli Zaretskii
2024-08-25 22:40                         ` Yuan Fu
2024-08-26 17:25                           ` Alan Mackenzie
2024-08-26 17:51                             ` Eli Zaretskii
2024-08-26 19:50                               ` Alan Mackenzie
2024-08-26 22:25                                 ` Stefan Kangas
2024-08-27  1:58                                   ` Yuan Fu
2024-08-27 12:09                                     ` Eli Zaretskii
2024-08-28  5:36                                       ` Yuan Fu
2024-08-28 12:33                                         ` Eli Zaretskii
2024-08-29  4:54                                           ` Yuan Fu
2024-08-29  6:01                                             ` Eli Zaretskii [this message]
2024-09-11  5:09                                               ` Yuan Fu
2024-09-11 12:09                                                 ` Eli Zaretskii
2024-09-12  8:06                                                   ` Yuan Fu
2024-08-27 12:01                                 ` Eli Zaretskii
2024-08-27 11:03                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y14fg95n.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64830@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=casouri@gmail.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).