From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73533: [PATCH] Rewrite speedbar expansion for all descendants Date: Sat, 19 Oct 2024 10:42:41 +0300 Message-ID: <86y12klery.fsf@gnu.org> References: <87y13blhu1.fsf@ice9.digital> <86a5fr5apb.fsf@gnu.org> <87v7yeeqig.fsf@ice9.digital> <87wmitfr8p.fsf@ice9.digital> <8734lhgfnn.fsf@ice9.digital> <87ttdm4f3d.fsf@ice9.digital> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13529"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73533@debbugs.gnu.org To: Morgan Willcock Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 19 09:44:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t248I-0003PT-6F for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Oct 2024 09:44:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t247g-0003rx-KB; Sat, 19 Oct 2024 03:43:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t247f-0003rj-B3 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 03:43:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t247f-0006TR-3V for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 03:43:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=q2cdl2RaTpzSl+6qjnZHV8a+pIH5PV1h0sXS/GxA9Qk=; b=Chn6P+W7IILXC5vaVVa+MNomyN2ZI0WznyQY/9l7QifOAezhLObfR/3G58U8s8foR2od/OHjLYxblmteQnFq9lqAAgx7UeWb/NyvmWCN3/dCwmWEnuFqprmSVlz/eI6gvshSkoPPVUD9tUELxAT/M8p2zxg1/7DSH+Lm9Is0szQ8BuxhzLeeVbHimlz4C7fOT9nc0Utj3bLencVa6jlK1lhs4JJMqQxhrRxzdxDZ0/D4aSafqEyDvqAYNoSAcogNtdrQg0Nz9UcTOFS4IA+uMHBJ+CC8kmU/ZqbP8vYKMSmaaZUlnMb7MnoQ0eZE83HFBI8MvzjA5nT7GZaD54rBIQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2482-0000Sv-Es for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 03:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Oct 2024 07:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73533-submit@debbugs.gnu.org id=B73533.17293237981716 (code B ref 73533); Sat, 19 Oct 2024 07:44:02 +0000 Original-Received: (at 73533) by debbugs.gnu.org; 19 Oct 2024 07:43:18 +0000 Original-Received: from localhost ([127.0.0.1]:41180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t247J-0000Rb-Ot for submit@debbugs.gnu.org; Sat, 19 Oct 2024 03:43:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t247H-0000RO-9m for 73533@debbugs.gnu.org; Sat, 19 Oct 2024 03:43:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t246n-0006Qg-Fb; Sat, 19 Oct 2024 03:42:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=q2cdl2RaTpzSl+6qjnZHV8a+pIH5PV1h0sXS/GxA9Qk=; b=nQDOu2EsdOu7 Wtcg0Dci1E5oT+pSWBKLDolhbjPx5y4MfdC4C6ceb48+U+1z/A42VhooByKpz/BIWJgMze/tO2g/r jXn1lH74qie5UHMdid2eEBt+Rwf2n9TE8G6MB4oZqjserrHtc/L1uNA2w8glhxh82L1uLv+4sKR/h QU2CxYEKkBGhEJ14K+SxQsh+thjrqTsyRfxfO76SnQsPkUpbOHpgdF/omGIED/Zx+p4d96LzDAy9R yYQ9W1mWa7sMdPI2apOSvTDT7VIV6+IVuJG7c3/BfCUQmWNDM3lsI3nyvTxvVcmTkoJdBHpi585dc Mpp/UIrqlRLCnyRyQVMJ7Q==; In-Reply-To: <87ttdm4f3d.fsf@ice9.digital> (message from Morgan Willcock on Tue, 08 Oct 2024 19:36:06 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293843 Archived-At: > From: Morgan Willcock > Cc: 73533@debbugs.gnu.org > Date: Tue, 08 Oct 2024 19:36:06 +0100 > > Attached is a patch for a replacement function and an additional patch > which adds tests for expanding all descendants. > > I couldn't see a direct way to test a Speedbar without creating a frame, > and because the Speedbar code doesn't implement any type of hierarchy > itself I've used eieio-speedbar to make something minimal to test. > > Each test runs by converting a list of strings into objects which > implement a Speedbar display, making state changes for the functions > being tested, and then converting the objects back into strings - this > was the simplest way I could find to create a reusable interface for > tests. The conversion back to a string is customizable to allow > whatever state change is under test to be represented. > > If the tests are problematic or considered too complicated, perhaps they > can just be used to test the current function and the replacement > function and not committed. The current function fails 3/9 tests. Thanks, I installed these patches on master. There seems to be still a problem with some files, in that speedbar-expand-line-descendants takes a very long time, and if I interrupt it with C-g, I see nested DEFUNs, something that shouldn't happen, because DEFUNs are never nested. E.g., try this: $ cd /path/to/emacs/src $ ./emacs -Q M-x speedbar RET At this point you should see all the files in the Emacs src directory. Go to androidfns.c and type '['. After about 10 sec type C-g. You should see nested DEFUns in the Speedbar frame. Could you please look into this?